feat: Renamed misleading method setCropzoneRect to setCropzoneRatio and created a setCropzoneRect method #746
Conversation
- Added method setCropzoneRect() - Renamed old method setCropzoneRect() to a more suitable name setCropzoneRatio() - Added a single unit test to ensure it works in its most basic scenario
|
Thank you very much. when will this feature be merged and published by the repository maintainer to NPM? |
| expect(cropper.getCropzoneRect()).toBeNull(); | ||
| }); | ||
| }); | ||
|
|
||
| describe('setCropzoneRect()', () => { | ||
| it('should set cropzone rectangle', () => { |
There was a problem hiding this comment.
This test is broken. Please check.
There was a problem hiding this comment.
How do you run tests btw? All the tests come out as broken on my end when I run jest because it doesn't resolve imports:
FAIL apps/image-editor/tests/flip.spec.js
● Test suite failed to run
Cannot find module '@/graphics' from 'apps/image-editor/tests/flip.spec.js'
1 | import { fabric } from 'fabric';
> 2 | import Graphics from '@/graphics';
| ^
3 | import Flip from '@/component/flip';
4 |
There was a problem hiding this comment.
Did you run npm run test on apps/image-editor?
| @@ -258,7 +258,7 @@ imageEditor.setBrush({ | |||
| width: 20, | |||
| color: '#FFFFFF', | |||
| }); | |||
| imageEditor.setCropzoneRect(1 / 1); | |||
| imageEditor.setCropzoneRatio(1 / 1); | |||
There was a problem hiding this comment.
Please add setCropzoneRect type test.
There was a problem hiding this comment.
Could you link me to a documentation on type test? I haven't seen these before
There was a problem hiding this comment.
It means this file. setCropzoneRect changed to setCropzoneRatio so setCropzoneRect is missing.
Running eslint on the project gives me 6 errors and 9 warnings. |
|
This issue has been automatically marked as inactive because there hasn’t been much going on it lately. It is going to be closed after 7 days. Thanks! |
close #596