-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setCropzoneRect method name is misleading + need a real method to set the cropzone rect #596
Comments
@Mouradif |
I've started working on it while still discovering the code, it may take a little time but I'll send a PR if they are welcome |
@Mouradif |
Any updates? |
My apologies, I got carried away with other stuff... I'll make the PR right away |
Here: #742 |
@Mouradif Can these two functions be used now? Why did I use it and it didn't work? |
Version 3.14.3
Development Environment Chrome on Ubuntu 20.04
Current Behavior
setCropzoneRect()
doesn't set the crop zone rectangle, instead it sets the ratio (should have been namedsetCropzoneRatio
maybe)Expected Behavior
since
getCropzoneRect
returns an object withtop
,left
,width
andheight
, one would expectsetCropzoneRect
to take as an argument a similar object and would expect that function to programmatically set the cropzone rectangle (which is what I'm trying to do)The text was updated successfully, but these errors were encountered: