Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setCropzoneRect method name is misleading + need a real method to set the cropzone rect #596

Open
Mouradif opened this issue May 19, 2021 · 7 comments
Labels
Enhancement Enhance performance or improve usability of original features. Need Discussion Need discussion or investigation

Comments

@Mouradif
Copy link

Mouradif commented May 19, 2021

Version 3.14.3

Development Environment Chrome on Ubuntu 20.04

Current Behavior

setCropzoneRect() doesn't set the crop zone rectangle, instead it sets the ratio (should have been named setCropzoneRatio maybe)

Expected Behavior

since getCropzoneRect returns an object with top, left, width and height, one would expect setCropzoneRect to take as an argument a similar object and would expect that function to programmatically set the cropzone rectangle (which is what I'm trying to do)

@Mouradif Mouradif added Enhancement Enhance performance or improve usability of original features. Need Discussion Need discussion or investigation labels May 19, 2021
@lja1018
Copy link
Contributor

lja1018 commented May 20, 2021

@Mouradif
Thank you for your suggestion.
I think that is a reasonable suggestion. I'll decide after having a meeting with the team.

@Mouradif
Copy link
Author

I've started working on it while still discovering the code, it may take a little time but I'll send a PR if they are welcome

@lja1018
Copy link
Contributor

lja1018 commented May 26, 2021

@Mouradif
Contributing is always welcome.
I'll be waiting for your PR.

@wenjing-pure
Copy link

Any updates?

@Mouradif
Copy link
Author

My apologies, I got carried away with other stuff... I'll make the PR right away

@Mouradif
Copy link
Author

Here: #742

@wenjing-pure
Copy link

@Mouradif Can these two functions be used now? Why did I use it and it didn't work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Enhance performance or improve usability of original features. Need Discussion Need discussion or investigation
Projects
None yet
3 participants