Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Renamed misleading method setCropzoneRect to setCropzoneRatio and created a setCropzoneRect method #742

Closed
wants to merge 1 commit into from
Closed

feat: Renamed misleading method setCropzoneRect to setCropzoneRatio and created a setCropzoneRect method #742

wants to merge 1 commit into from

Conversation

Mouradif
Copy link

@Mouradif Mouradif commented Mar 24, 2022 •
edited

  • Added method setCropzoneRect()
  • Renamed old method setCropzoneRect() to a more suitable name setCropzoneRatio()
  • Added a single unit test to ensure it works in its most basic scenario

close #596

@Mouradif
Created method to set the cropzone rectangle
b541bc8 
- Added method setCropzoneRect()
- Renamed old method setCropzoneRect() to a more suitable name setCropzoneRatio()
- Added a single unit test to ensure it works in its most basic scenario
@Mouradif Mouradif changed the title Created method to set the cropzone rectangle feat: Renamed misleading method setCropzoneRect to setCropzoneRatio and created a setCropzoneRect method Mar 24, 2022
@Mouradif Mouradif mentioned this pull request Mar 24, 2022
Open
@wenjing-pure
Copy link

Can these two functions be used now? Why did I use it and it didn't work?

@wenjing-pure
Copy link

Do I need to reinstall tui-image-editor?

@Mouradif
Copy link
Author

@wenjing-pure if you're using the tui-image-editor from npm registry, it doesn't include this update. If you want to try this feature, it's probably best that you wait until this feature is merged and published by the repository maintainer to NPM.

Otherwise you can clone my branch but you will have errors with all the import statements

@wenjing-pure
Copy link

OK, I look forward to your update as soon as possible！！
thank U

@wenjing-pure
Copy link

please, when can you merge branches? I want to use it as soon as possible.

@Mouradif
Copy link
Author

@wenjing-pure please stop spamming. Head over to the issues and ask for help on your use case

@lja1018
Copy link
Contributor

lja1018 commented Mar 30, 2022

@Mouradif
Why is this PR closed?

@Mouradif
Copy link
Author

I'm sorry, I had no idea how to stop the Github actions from running (and failing due to some authentication step)

Here's the new one (identical): #746

@lja1018
Copy link
Contributor

lja1018 commented Mar 30, 2022

@Mouradif
I checked it. I will review it.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenjing-pure wenjing-pure wenjing-pure approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

setCropzoneRect method name is misleading + need a real method to set the cropzone rect
3 participants
@Mouradif @wenjing-pure @lja1018