fix: fixed Text object -> ITextObject (fix #262 #109) #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinwoo-kim-nhn
changed the title
| @@ -175,7 +175,6 @@ class ImageEditor { | |||
| this.ui ? this.ui.getEditorArea() : wrapper, { | |||
| cssMaxWidth: options.cssMaxWidth, | |||
| cssMaxHeight: options.cssMaxHeight, | |||
| useItext: !!this.ui, | |||
There was a problem hiding this comment.
기본 ui 일때만 itext 를 쓰도록 되어있었네요, 기본 ui를 사용 하지 않는 경우에도 문제가 없나요?
There was a problem hiding this comment.
넵 확인 해봤었는데 문제 없었고, 휴직 전에 작업해던거라서.. 한번 더 확인해보겠습니다.
dongsik-yoo
reviewed
Jun 10, 2020
src/js/component/text.js
Outdated
| @@ -605,8 +516,8 @@ class Text extends Component { | |||
| const newClickTime = (new Date()).getTime(); | |||
|
|
|||
| if (target.isEditing || this._isDoubleClick(newClickTime)) { | |||
| if (!this.useItext) { | |||
| this._changeToEditingMode(target); | |||
| if (!target.isEditing) { | |||
There was a problem hiding this comment.
target.isEditing 조건문이 true인 경우에도 이 라인까지 들어왔다가 이벤트를 날리네요. 에디팅 중에 마우스업이나 더블 클릭인 경우 이벤트가 다시 한 번 더 날아갈 것 같은데 문제 없는지 확인 필요해 보여요.
There was a problem hiding this comment.
넵 이부분 확인해보고 수정하겠습니다. 리뷰 감사합니다
dongsik-yoo
reviewed
Jun 10, 2020
HerlinMatos
pushed a commit
to EveryMundo/tui.image-editor
that referenced
this pull request
Jul 2, 2020
* fix: fixed Text object -> ITextObject * apply codereview Co-authored-by: jwc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
fix #xxx[,#xxx], where "xxx" is the issue number)Description
버그 원인
해결방법
모바일에서의 itext 버그 해결된 부분 확인
Thank you for your contribution to TOAST UI product. 🎉 😘 ✨