Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text edit mode in mobile #262

Closed
joseduin opened this issue Oct 31, 2019 · 2 comments
Closed

Text edit mode in mobile #262

joseduin opened this issue Oct 31, 2019 · 2 comments
Labels
Milestone

Comments

@joseduin
Copy link

Version

3.7.0

Development Environment

Mobile

Current Behavior

When I finish editing a text, the text does not exit the editing mode when I click outside the text
Captura de Pantalla 2019-10-31 a la(s) 13 53 08

Expected Behavior

The text should leave the edit mode, it seems an error with the click event

Alternative solution

We must force the 'blur' event of textarea when we detect that we enter the edit mode

imageEditor.on({
      textEditing: () => { this._editing = true; },
      mousedown: (event, originPointer) => {
      if (this._editing) {
        var textarea = document.querySelector('textarea.tui-image-eidtor-textarea');
        this.renderer.invokeElementMethod(textarea, 'blur', []); // force 'blur'
        this._editing = false;
      }
       },
    });
@junghwan-park
Copy link
Member

@joseduin Thank you for reporting. I'll fix this next release.

@junghwan-park junghwan-park added this to the v3.8.0 milestone Nov 8, 2019
@jinwoo-kim-nhn jinwoo-kim-nhn modified the milestones: v3.8.0, 2.11.0 Jan 23, 2020
@av-k
Copy link

av-k commented Mar 12, 2020

Hi @junghwan-park!
Any updates?
What the priority of that issue?

HerlinMatos pushed a commit to EveryMundo/tui.image-editor that referenced this issue Jul 2, 2020
* fix: fixed Text object -> ITextObject

* apply codereview

Co-authored-by: jwc <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants