Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double click for editing text don't work well on ionic project #429

Closed
StefanMartel opened this issue Jul 16, 2020 · 4 comments
Closed

Double click for editing text don't work well on ionic project #429

StefanMartel opened this issue Jul 16, 2020 · 4 comments
Labels

Comments

@StefanMartel
Copy link

Hi,

i work on a angular 9 / ionic 5 / tui-image-editor 3.9.0 project so i choose to work like the example01-includeUi.html and the implementation works well.

The problem is on device (samsung S20 and other) when i double click on a text, it moves a little but i can't edit it (the textEditing event is not launch), it works only 1 on 10.

I try the example03-mobile.html on my phone samsung S20 and i don't have this problem, everything works fine, the https://github.com/nhn/tui.image-editor/blob/master/examples/example02-useApiDirect.html exemple works fine too on my phone.

Is there a différence between the includeUi and the javascript implementation ?
Is there a way to have the double click works well on includeUi project on mobile?

Regards,
Stefan

@auto-comment
Copy link

auto-comment bot commented Jul 16, 2020

Thank you for raising an issue.
We will try and get back to you as soon as possible.

Please make sure you have filled out issue respecting our form in English and given us as much context as possible. If not, the issue will be closed or not replied.

@jinwoo-kim-nhn
Copy link
Contributor

Does this mean it doesn't work in the includeUI version? If it works well in other examples, I think it might be improved in includeUI. Let's test it more and let me know the progress.

@jinwoo-kim-nhn
Copy link
Contributor

jinwoo-kim-nhn commented Jul 17, 2020

I checked this part. It has already been improved and reflected in the master. We will release the revised feature in a new version soon.( Fixed with #352 )

@StefanMartel
Copy link
Author

Yes it didn't work on the includeUI Version.
But i installed the new alpha version (3.10.0-alpha.0) and it works with it.

So it's great ^^
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants