Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Fast kmerf #369

Merged
merged 13 commits into from
May 24, 2023
Merged

Add Fast kmerf #369

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
dae3d50
make kmerf fast
sampan501 May 14, 2023
1feb62e
use kernel on y as well
sampan501 May 15, 2023
52de382
update kmerf kernel
sampan501 May 15, 2023
12d6896
remove weird import
sampan501 May 16, 2023
c85906e
fix k-sample-transform rf
sampan501 May 16, 2023
6ace768
make error trace better
sampan501 May 16, 2023
58ffdfa
fix ksample rf k-sample-transform
sampan501 May 16, 2023
1c5a4f8
cast v to int for k-sample
sampan501 May 16, 2023
155c2dc
fix kmerf p-values
sampan501 May 16, 2023
786cbd3
update kmerf k-sample
sampan501 May 16, 2023
65229d2
fix kmerf unit tests
sampan501 May 17, 2023
8a343c3
fix build errors
sampan501 May 17, 2023
6f95ab7
remove is_ksamp after saving the values
sampan501 May 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
cast v to int for k-sample
  • Loading branch information
@sampan501
sampan501 committed May 16, 2023
commit 1c5a4f8ae3561e6a10b58fe37b041bf00c4a7805
6 changes: 3 additions & 3 deletions hyppo/independence/tests/test_kmerf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ class TestKMERFStat(object):
@pytest.mark.parametrize(
"sim, obs_stat, obs_pvalue",
[
(linear, 0.253, 1.0), # test linear simulation
(spiral, 0.037, 1.0), # test spiral simulation
(multimodal_independence, -0.0363, 1.0), # test independence simulation
(linear, 1.0, 1.0), # test linear simulation
(spiral, 0.1835550720881665, 1.0), # test spiral simulation
(multimodal_independence, -0.0059788, 1.0), # test independence simulation
],
)
def test_oned(self, sim, obs_stat, obs_pvalue):
Expand Down
2 changes: 1 addition & 1 deletion hyppo/ksample/ksamp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ def statistic(self, *args):
else:
u, v = k_sample_transform(inputs)

return self.indep_test.statistic(u, v)
return self.indep_test.statistic(u, v.astype(int))

def test(self, *args, reps=1000, workers=1, auto=True, random_state=None):
r"""
Expand Down