Shipping method improvements #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, editing an instance of Spree::Event::Subscriber would result in not being reloaded or being subscribed twice. With this change each includer of Event::Subscriber is registered by its name and later unsubscribed just before class unload (using old module instance), then resubscribed after the new code is loaded.
And mimic the behavior of Array#concat.
Avoid usage of toplevel classes.
Was only used in a spec and has no practical purpose.
…api-docs Document the API via OpenAPI
…s-and-defaults Support class reloading for Event Subscribers
…r-and-event-extension-fixes Some fixes for ClassConstantizer and EnvironmentExtension
…conf Improve gem-release configuration
Otherwise it would raise an error when this file is loaded before spree/core, for example while executing a rails generator in /core directory.
…ubscriber-require Require spree/event/subscriber before using it
…op-rules Update Rubocop config
…api-doc-link Refer users to Stoplight for API reference
The docker image that we are using for mysql has been recently updated. https://hub.docker.com/r/circleci/mysql This update changed some internal path or library that were cached into our gem cache in circleci for `mysql2 0.5.2`. This happens because native extensions are cached along with the gems and are not rebuilt at every job run. To clear CircleCI cache we can only change the cache key to rebuild it from scratch, as described in their docs: https://circleci.com/docs/2.0/caching/#clearing-cache
…rcle-cache Bump CircleCi gems cache key
To respect the standard formatting of the rest of guides.
…ts-guides Improve Spree::Event guides
…selected Add a color to menu selected items
Add missing v2.9 CHANGELOG entries
When reviewing PRs for the admin/frontend sections that include visual changes, it's very handy to be able to visualize these changes without resorting to check out the code, starting the server and navigating to the modified pages.
This commit fixes the sample config by using `=` instead of `==` for setting the `admin_vat_country_iso`
We get a good amount of people completing the installation and setup of a Solidus store, but unsure about how to start customizing it showing up in Slack and asking questions which might be answered by these guides. The logical next step after installing Solidus on a store is to start customizing it, so I think it makes sense to send people to the customization guides here as a first step.
The coupon code styling seems to be broken in Firefox compared to Chrome and Safari. These changes should ensure it fits nicely and consistent between browsers.
…oplight-studio-docs Document contribution guidelines for API docs
When calculating total tab width, we recently saw a case where there were no tabs and thus no IV for reduce. This adds a default starting value of 0 which prevents a js exception.
…at-documentation [doc] Document the config assigment for vat_country_iso
…-guides Link to guides after installation instructions
Deprecation messages on `CreditCard#default` and `CreditCard#default=` are a bit misleading, as they print out `CreditCard.default` but they are actually referencing an instance method, not a class one.
Fix Coupon Code Field's Length in Firefox
…e_for_tab_widths Add initial value to reduce function for tab widths
Sprockets 4 uses manifest files[1], and the default manifest.js links `app/assets/images`. To prevent it from crashing due to the directory not being present, the easiest solution is to create an empty `app/assets/images` directory. [1]: https://github.com/rails/sprockets/blob/master/UPGRADING.md#manifestjs
…prockets-4 Fix Sprockets 4 support for extensions
A recent update of the project's sample product branding added new images, and product names to the seeds: solidusio@8221dcb These images are no longer being used, and can be removed.
…gh-pr-template Ask to provide screenshots for PRs with visual changes
…docs Correct misspelling in API Documentation for Create Product
…ecation-message Fix deprecation message for Spree::CreditCard
Left menu was not expanded when trying to manage store credit reasons
Remove unused sample images
- Clarifies examples - Fixes grammatical inconsistencies
Update guides and add mailer customization guide
Update CONTRIBUTING.md [ci skip]
Fixing admin store credit reasons tab not expanded
|
Sorry :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist: