Add a color to menu selected items #3269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kennyadsl thanks for your reporting! |
kennyadsl
approved these changes
Jul 12, 2019
|
@mfrecchiami can you please rebase against the updated upstream master to fix the specs? |
mfrecchiami
force-pushed
the
mfrecchiami/menu-item-selected
branch
from
37be5d4
to
9e2499e
Compare
spaghetticode
approved these changes
Jul 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's an issue related to my previous PR (the update of colors palette): when there is a first level menu item, the user can't understand in which section he actually is, if he look only at the sidebar navigation (e.g.: Orders or Users) because any color or background, changes on the first level menu items (see picture below):
This is a mistake done thought about the future possibility of a navigation without popover but with an active dropdown (like most of modern navigation sidebar).
So, I add a background color on the first level menu item that has the
.selectedclass.This is the result: