Ask to provide screenshots for PRs with visual changes #3385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When reviewing PRs for the admin/frontend sections that include visual changes, it's very handy to be able to visualize these changes without resorting to check out the code, starting the server and navigating to the modified pages.
spaghetticode
force-pushed
the
spaghetticode/improve-gh-pr-template
branch
from
9717e34
to
ee3bfb6
Compare
jacobherrington
approved these changes
Oct 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When reviewing PRs for the admin/frontend sections that include visual
changes, it's very handy to be able to visualize these changes without
resorting to checking out the code, starting the server and navigating
to the modified pages.
Checklist: