Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modkit BED file impropperly formatted. #108

Open
KloostermanJoukje opened this issue Jan 5, 2024 · 2 comments
Open

Modkit BED file impropperly formatted. #108

KloostermanJoukje opened this issue Jan 5, 2024 · 2 comments

Comments

@KloostermanJoukje
Copy link

KloostermanJoukje commented Jan 5, 2024

Hello,

Another issue (#97) had the same issue as i had. And It was written that the issue would be fixed by relase 0.2.4 however when using this release, still the bed file is impropperly formatted:

improperly formatted BED line chr22 18890487 18890487
improperly formatted BED line chr22 38110048 38110048
improperly formatted BED line chrX 153909598 153909598

any idea when this will be implemented? Or how to fix it?

@KloostermanJoukje
Copy link
Author

To create the bed file I perform the following:

local args=()
args+=("view")
args+=("--no-header")
args+=("--no-version")
args+=("--threads" "!{task.cpus}")
args+=("!{vcf}")

# -1 because positions in .bed are 0-based and 1-based in .vcf
${CMD_BCFTOOLS} "${args[@]}" | awk -v FS='\t' -v OFS='\t' '{print $1 "\t" $2-1 "\t" $2-1 "\t"}' > "!{vcf.simpleName}.bed"

@ArtRand
Copy link
Contributor

ArtRand commented Jan 6, 2024

Hello @JoukjeKloosterman,

In the latest release modkit still requires the strand information in the --include-bed files. I wanted to remove this requirement in 0.2.4, but it didn't make it. If you add . as the strand for all of your BED lines, that should fix the problem (as suggested in #97). The plan is to remove this requirement (default to both strands) in the next release.

ArtRand added a commit that referenced this issue Mar 5, 2024
Allow BED3 for --include-bed options.

See merge request machine-learning/modkit!149
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants