Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button to move soundfont to top #5269

Closed
wants to merge 2 commits into from
Closed

Add button to move soundfont to top #5269

wants to merge 2 commits into from

Conversation

barafael
Copy link
Contributor

This branch adds a button to the soundfont selector (View -> Synthesizer -> Fluid tab). The button moves the currently selected item to the top, changing the playback soundfont.

Previously, one had to repeatedly click the "Move soundfont up" button.

Note: This is affected by issue #276456, which I created. I verified that the issue persists without my changes.

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Aug 17, 2019

  • That merge commit shouldn't be there
  • Please include "Fix #276456: " in the commit title (and also in the PR title), so that issue automagically closed when this PR gets merged. Hmm, hold on, that one got fixed last December already?!
  • Did you sign the CLA or are you rafaelement there?

@anatoly-os
Copy link
Contributor

@Jojo-Schmitz regarding CLA, see #3983

@barafael you need to git rebase master instead of merging with the master branch. Could you please delete the merge commit and rebase the changes on top of the master branch? Or create new PR with your changes only?

@Harmoniker1
Copy link
Contributor

Haven't heard from the author of this PR for over a month? In this case according to the PR merge process shouldn't this be closed? (but this is still a very useful suggestion)

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Oct 2, 2019

It'd indeed be a pity to loose this, it could still get cherry-picked.
But it'd really be best it @barafael would fix it as per our reviews.

@anatoly-os anatoly-os added this to the MuseScore 3.3.1 milestone Oct 3, 2019
anatoly-os added a commit to anatoly-os/MuseScore that referenced this pull request Oct 28, 2019
@anatoly-os
Copy link
Contributor

See #5429

@anatoly-os anatoly-os closed this Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
work in progress not finished work or not addressed review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants