fix #276840: Soundfont selector: button to move soundfont to top #3983
Conversation
|
Thank you for your contribution. We thought about "Apply" button which should apply all changes made after using arrows to change the place of the soundfonts. Your solution is good as well. |
|
I have signed the CLA. |
|
@barafael could you please create the issue in the tracker which describes the main reason of these changes. It is useful to track related changes in the future. |
|
Travis fails, it looks like due a package management issue. I squashed my commits but did not change the code. If there is something I need to do (like cherry pick from master) let me know. |
|
Some internal error, I've restarted the build. |
|
IMHO one possible implementation of this feature would be to have a drop-down list of soundfonts. I am willing to try to implement this, are you open for this change? |
|
@barafael what are advantages of the proposed approach? I think having "move to top" already does its job. Btw, you also need to add this widget and related logic to Zerberus synth. |
|
@anatoly-os right now the purpose of the up/down buttons is unclear, that is why I thought to experiment a bit. |
|
The buttons in fluid and zerberus are now grayed out when the list is empty or the first/last element is selected. I changed the code in the zerberus updateButtons function as it didn't correctly en/disable the buttons correctly. I hope it has no other side effects. The weird bug where the soundfont list is growing with every reload does NOT affect the zerberus list, by the way. |
|
@barafael please add "fix #276840:" at the beginning of the commit message so the related issue could be closed automatically. UPD: which username did you use in CLA? |
|
I used username "rafaelement": https://musescore.org/en/user/31589 which is my old forum name. |
|
Please let me know if there is anything else I need to do or if there is something wrong with the CLA. |
|
If there is nothing more to do here, I will delete the branch and close the PR. |
|
Let me look at this PR again tomorrow. I'll leave the comment once I refresh my memory. |
|
@barafael could you please rebase the changes on top of the master branch? The changes look good and should have been merged earlier... |
Extend rectangle of page box to cover all score's area in continious view mode.
and Staff text change text's Notehead scheme drop down
as the workaround for Qt lupdate bug https://bugreports.qt.io/browse/QTBUG-35164 not only is no longer needed as of Qt 5.9.0 Beta 2, but now also harms.
Fix path for gen-ref.bat
…hat led to crashes Also clarify the meaning of ScoreTab::setCurrent, setExcerpt, setCurrentIndex
…ome tuplets owned to another staff causes crash
|
I think this is beyond my merge-fu. I'd rather open a new pull request with the same changes. |
|
@barafael are you still planning to open a new pull request on this? |
|
No, I don't think I will. |
|
OK, I'm on it now |
This branch adds a button to the soundfont selector (View -> Synthesizer -> Fluid tab). The button moves the currently selected item to the top, changing the playback soundfont.
Previously, one had to repeatedly click the "Move soundfont up" button.
Note: This is affected by issue #276456, which I created. I verified that the issue persists without my changes.