Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR candidates to be merged to MuseScore 3.3 Beta 2 #5298

Closed
14 of 17 tasks
anatoly-os opened this issue Sep 3, 2019 · 7 comments
Closed
14 of 17 tasks

PR candidates to be merged to MuseScore 3.3 Beta 2 #5298

anatoly-os opened this issue Sep 3, 2019 · 7 comments

Comments

@anatoly-os
Copy link
Contributor

anatoly-os commented Sep 3, 2019

Pull requests in the list fix the P0 and P1 issues from the issue tracker or were suggested by the community or selected by in-house team.

Included to MuseScore 3.3 Beta 2:

@Jojo-Schmitz
Copy link
Contributor

Please consider #5291 and #5297

@jthistle
Copy link
Contributor

jthistle commented Sep 3, 2019

I very much like that we're organizing things like this, but GitHub does provide the 'milestone' feature for exactly things like this - maybe it would make it slightly easier to do it like that for the next milestone? Just an idea :)

@anatoly-os
Copy link
Contributor Author

@jthistle I tried to organise the project, but it was something different. I'll take a look, thanks!

@jthistle
Copy link
Contributor

jthistle commented Sep 3, 2019

Yes, projects are more for full workflows, i.e. you put a bug in the first column, someone takes it on and moves it to the next column, when it's fixed it gets moved on and so on. It works well for smaller projects, but isn't really what we want here, AFAIK. Milestones seem like exactly what we might want though; it's just a way of tagging PRs to be merged for a specific date/version.

@mattmcclinch
Copy link
Contributor

Please also consider #5295, as it fixes a recent regression.

@Harmoniker1
Copy link
Contributor

Harmoniker1 commented Sep 5, 2019

#5300, #5303 and #5315 all do some non-trivial improvement. I hope you can consider them.

@DLLarson
Copy link
Contributor

DLLarson commented Sep 10, 2019

#5259 has the comment "selection is an error-prone field".

How so? It's an additive feature so can't break existing code. The code changes are not complex.

No inspection comments have been made to support this judgement.

-Dale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants