279877 continuousview #5255
Closed
279877 continuousview #5255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Made code for finding height of panel more readable - Extended vertical padding around the panel for aesthetic reasons
- Should stop text from going past the panel
- Fix for issue #27987
|
Please squash the commits and add "fix #279877" to the commit title |
This was referenced Aug 29, 2019
njvdberg
reviewed
Oct 20, 2019
| else { | ||
| painter.setMatrixEnabled(false); | ||
| painter.setMatrixEnabled(false); // Paints background when custom backing is used | ||
| painter.drawTiledPixmap(bg, *fgPixmap, bg.topLeft() | ||
| - QPoint(lrint(_sv->matrix().dx()), lrint(_sv->matrix().dy()))); | ||
| painter.setMatrixEnabled(true); |
There was a problem hiding this comment.
Instead of all these changes I found it is enough to remove the lines 284/288 and 287/291 to solve issue 279877.
| @@ -28,6 +28,7 @@ | |||
| #include "preferences.h" | |||
| #include "scoreview.h" | |||
| #include "continuouspanel.h" | |||
| #include <QDebug> | |||
There was a problem hiding this comment.
Should not be needed, as it is in all.h
| for (int i = 0; i < _score->nstaves(); ++i) { | ||
| qreal _padding = 8 * _spatium; | ||
| _y = system->staffYpage(0) + system->page()->pos().y() - _padding; | ||
| double _staff_height = 0.0; |
| QList<StaffName>& staffNamesLong = currentStaff->part()->instrument(Fraction::fromTicks(tick))->longNames(); | ||
| QString staffName = staffNamesLong.isEmpty() ? " " : staffNamesLong[0].name(); | ||
| QString staffName = staffNamesLong.isEmpty() ? "" : staffNamesLong[0].name(); |
There was a problem hiding this comment.
an empty string is different from one containing a space, is this really intended here?
| @@ -1 +1 @@ | |||
| 3543170 | |||
| 19679cf | |||
There was a problem hiding this comment.
This change needs to go, revision.h should never ever be made part of a commit
| QPixmap* fgPixmap = _sv->fgPixmap(); | ||
| if (fgPixmap == 0 || fgPixmap->isNull()) | ||
| if (fgPixmap == 0 || fgPixmap->isNull()) { |
|
@rajansaini691 please reopen when you are around to address the code review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved background layout of continuous view and fixed issue 279877