fix #293897: [Tablature] Note value repeat section: setting "Never" broken #5295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wait, though, is that correct? I would have thought that meant literally don't repeat the duration symbol later, but still show it at the point of change. |
|
Yes, you are correct. My description was worded poorly, so I have edited it to make it clearer. This does not prevent tablature duration symbols from being shown at the point of change, because in that case, an earlier condition would have evaluated to true. |
17 tasks
anatoly-os
reviewed
Sep 4, 2019
libmscore/chord.cpp
Outdated
| @@ -2285,6 +2285,8 @@ void Chord::layoutTablature() | |||
| || prevCR->tuplet() != tuplet() | |||
| || prevCR->type() == ElementType::REST) | |||
| needTabDur = true; | |||
| else if (tab->symRepeat() == TablatureSymbolRepeat::NEVER) | |||
| ; // No tab duration symbol needed | |||
There was a problem hiding this comment.
This code will lead to a warning on most compilers. Can the code be rearranged to avoid empty if case?
…roken This followup to 3cd5154 makes sure not to create tablature duration symbols when "Repeat" is set to "Never".
7208306
to
e53bd27
Compare
|
Okay, I rearranged the code to avoid the empty |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/en/node/293897.
This followup to 3cd5154 makes sure not to repeat tablature duration symbols when "Repeat" is set to "Never".