Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow buffer argument to VoxelManip:get_light_data #12682

Merged
merged 1 commit into from
Aug 13, 2022
Merged

Allow buffer argument to VoxelManip:get_light_data #12682

merged 1 commit into from
Aug 13, 2022

Conversation

TurkeyMcMac
Copy link
Contributor

This is just a trivial addition. It brings get_light_data in line with get_data and get_param2_data.

To do

This PR is Ready for Review.

How to test

The code changes are minimal. You can just run some code that provides a buffer to get_light_data, I guess.

@Zughy Zughy added Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines Code quality labels Aug 10, 2022
sfan5
sfan5 approved these changes Aug 10, 2022
View reviewed changes
Copy link
Member

@sfan5 sfan5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfan5 sfan5 added @ Script API One approval ✅ ◻️ Feature ✨ PRs that add or enhance a feature and removed Code quality labels Aug 10, 2022
SmallJoker
SmallJoker approved these changes Aug 13, 2022
View reviewed changes
Copy link
Member

@SmallJoker SmallJoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SmallJoker SmallJoker merged commit ab8dfb4 into minetest:master Aug 13, 2022
@grorp grorp mentioned this pull request Mar 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfan5 sfan5 sfan5 approved these changes

@SmallJoker SmallJoker SmallJoker approved these changes

Assignees
No one assigned
Labels
Feature ✨ PRs that add or enhance a feature @ Script API Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines >= Two approvals ✅ ✅
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@TurkeyMcMac @sfan5 @SmallJoker @Zughy