Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vm:get_light_data does not accept a buffer #13294

Closed
Kimapr opened this issue Mar 7, 2023 · 1 comment
Closed

vm:get_light_data does not accept a buffer #13294

Kimapr opened this issue Mar 7, 2023 · 1 comment
Labels

Comments

@Kimapr
Copy link

Kimapr commented Mar 7, 2023

Minetest version
5.6.1
Summary

I've been working on a mod that uses VoxelManips and found that vm:get_light_data didn't use the buffer i passed to it, while vm:get_data and vm:get_param2_data did. While this is correctly described in the documentation, it's not something anyone would expect.

Steps to reproduce
local vm = ... -- acquire a voxelmanip
local data,data1,data2={},{},{}
vm:get_data(data) -- `data` is filled with data
vm:get_param2_data(data2) -- `data2` is also filled with data
vm:get_light_data(data1) -- `data1` is NOT filled with data (!!!)
assert(#data1>0) -- fails
@Kimapr Kimapr added the Unconfirmed bug Bug report that has not been confirmed to exist/be reproducible label Mar 7, 2023
@grorp
Copy link
Member

grorp commented Mar 7, 2023

Fixed by #12682?

@sfan5 sfan5 added Invalid and removed Unconfirmed bug Bug report that has not been confirmed to exist/be reproducible labels Mar 7, 2023
@sfan5 sfan5 closed this as completed Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants