Force-update shadows when the world is changed #12364
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix the "lagging shadows" problem when
shadow_update_frames
setting is greater than 1.shadow_update_frames
setting was introduced to mitigate the performance degradation caused by shadow mapping and spreads rendering of the 'map' shadow over the given number of frames. This delays change in the shadow when the map changes (mining or building) and causes artifacts such as nodes not casting shadows on building or shadows cast by air on mining.This PR forces a full SM render on the frame where a map change occurs, removing the lag completely.
The downside is that shadow update frequency is not even, which may be noticeable with fast-moving shadows (e.g. shadows of high cliffs).
To do
This PR is a Ready for Review.
How to test