Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default settings, presets and configuration for dynamic shadows #12359

Merged
merged 6 commits into from
May 29, 2022

Conversation

x2048
Copy link
Contributor

@x2048 x2048 commented May 20, 2022

This PR tunes the way dynamic shadows are configured on the client:

The new presets follow these ratios with every quality level:

  • Texture resolution is doubled (x2)
  • Max shadow distance is multiplied by 1.5

The result is that pixel density and shadow quality near player also increases with every preset.

To do

This PR is a Work in Progress

How to test

  1. Start minetest
  2. Go to settings, enable shaders
  3. Change the presets for dynamic shadows.

@x2048 x2048 added @ Client / Audiovisuals Discussion Issues meant for discussion of one or more proposals @ Builtin labels May 20, 2022
@x2048 x2048 self-assigned this May 20, 2022
@x2048
Copy link
Contributor Author

x2048 commented May 20, 2022

Modified look:
image

@x2048 x2048 added the WIP The PR is still being worked on by its author and not ready yet. label May 20, 2022
@kilbith
Copy link
Contributor

kilbith commented May 21, 2022

Give me that instead and get rid of the shadow update frames bullshit.

@x2048 x2048 changed the title Shadow defaults Default settings, presets and configuration for dynamic shadows May 21, 2022
@x2048
Copy link
Contributor Author

x2048 commented May 21, 2022

I've made two polls on Discord, here are the results:

image

image

I have reduced maximum rendering distance for many presets based on this feedback, to favor more quality over coverage. I also doubled shadow map resolution for High and Ultra High, going for 8192 in Ultra High.

@lhofhansl
Copy link
Contributor

I don't think we even need that max-shadow distance as config option.
We can always make it view_range * 1.5.

@rubenwardy rubenwardy added the Roadmap The change matches an item on the current roadmap label May 23, 2022
@x2048
Copy link
Contributor Author

x2048 commented May 23, 2022

@lhofhansl Going to very high view range will kill the shadow quality near the player, and shadow distance is not a priority for high-quality preset. I still think we should have a limit for shadow range.

@lhofhansl
Copy link
Contributor

So with #12364 and can leave shadow_update_frames the way it is, right?

builtin/settingtypes.txt Outdated Show resolved Hide resolved
@x2048 x2048 removed WIP The PR is still being worked on by its author and not ready yet. Discussion Issues meant for discussion of one or more proposals labels May 26, 2022
@x2048
Copy link
Contributor Author

x2048 commented May 26, 2022

So, this is the current proposal. The presets are as follows:

Preset Texure resolution Maximum Range Filtering Effects
Very Low 512 62 No filtering None
Low 1024 93 No filtering None
Medium 2048 140 3x3 / 9 None
High 4096 210 5x5 / 25 Colored Shadows
Very High 8192 300 5x5 / 25 Colored Shadows

Comments, feedback are welcome.

@lhofhansl
Copy link
Contributor

Hard to say whether these pre-sets are good for everyone. These seem to be good enough.

@lhofhansl
Copy link
Contributor

lhofhansl commented May 27, 2022

I still would like if we could derive more things: For example the max shadow distance and shadow map resolution from the view range instead of specific config options... But I happily take this.

Copy link
Member

@SmallJoker SmallJoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; works.

@sfan5 sfan5 merged commit 25ba9d8 into minetest:master May 29, 2022
@x2048 x2048 deleted the shadow_defaults branch July 28, 2022 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

State that dynamic shadows, even if activated, need games/mods to opt-in to be displayed
6 participants