1040 - 2/3 Add ALB behind API's NLB to avoid errors on restart #2299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e864110
to
a51fd10
Compare
leite08
commented
Jun 19, 2024
There was a problem hiding this comment.
Just some change I had local and think its useful for debugging purposes
leite08
commented
Jun 19, 2024
| @@ -428,6 +429,7 @@ export class APIStack extends Stack { | |||
| }, | |||
| cookieStore, | |||
| }); | |||
| const apiLoadBalancerAddress = apiLoadBalancer.loadBalancerDnsName; | |||
There was a problem hiding this comment.
Differentiate between LB address (needed for API GW integration) and "direct" access address that points to the ALB (so lambdas don't need the additional network hop of going through the NLB to get to the API).
leite08
commented
Jun 19, 2024
Comment on lines
330
to
546
| // This speeds up deployments so the tasks are swapped quicker. | ||
| // See for details: https://docs.aws.amazon.com/elasticloadbalancing/latest/application/load-balancer-target-groups.html#deregistration-delay | ||
| fargateService.targetGroup.setAttribute("deregistration_delay.timeout_seconds", "17"); | ||
|
|
||
| // This also speeds up deployments so the health checks have a faster turnaround. | ||
| // See for details: https://docs.aws.amazon.com/elasticloadbalancing/latest/network/target-group-health-checks.html | ||
| fargateService.targetGroup.configureHealthCheck({ | ||
| healthyThresholdCount: 2, | ||
| interval: Duration.seconds(10), | ||
| }); | ||
|
|
There was a problem hiding this comment.
Moved these to be close to the LB/TG definitions
jonahkaye
reviewed
Jun 19, 2024
jonahkaye
reviewed
Jun 19, 2024
jonahkaye
reviewed
Jun 19, 2024
Great question! I was so focused on fixing this quickly that I didn't think about this. I'm splitting this in three PRs:
|
5 tasks
9af3740
to
eb859b5
Compare
5 tasks
jonahkaye
approved these changes
Jun 19, 2024
3b92645
to
3f316aa
Compare
Ref. metriport/metriport-internal#1040 Signed-off-by: Rafael Leite <[email protected]>
eb859b5
to
11c2797
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref. metriport/metriport-internal#1040
Dependencies
Description
Point infra to use the ALB version of the API's - context
Testing
executeWithNetworkRetriesis not on base branch yet (develop)Release Plan