-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1040 - 1/3 Create ALB version of the API #2303
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
leite08
requested review from
Goncharo,
Orta21,
RamilGaripov,
jonahkaye and
thomasyopes
as code owners
June 19, 2024 19:56
jonahkaye
approved these changes
Jun 19, 2024
leite08
force-pushed
the
1040-alb-behind-api-nlb_1
branch
from
June 19, 2024 22:33
9681781
to
1a97fc9
Compare
Ref. metriport/metriport-internal#1040 Signed-off-by: Rafael Leite <[email protected]>
Ref. metriport/metriport-internal#1040 Signed-off-by: Rafael Leite <[email protected]>
Ref. metriport/metriport-internal#1040 Signed-off-by: Rafael Leite <[email protected]>
leite08
force-pushed
the
1040-alb-behind-api-nlb_1
branch
from
June 19, 2024 22:51
aceb133
to
b98da94
Compare
leite08
force-pushed
the
1040-alb-behind-api-nlb_1
branch
from
June 19, 2024 23:17
b98da94
to
3b92645
Compare
Ref. metriport/metriport-internal#1040 Signed-off-by: Rafael Leite <[email protected]>
leite08
force-pushed
the
1040-alb-behind-api-nlb_1
branch
from
June 19, 2024 23:57
3b92645
to
3f316aa
Compare
thomasyopes
approved these changes
Jun 20, 2024
Ref. metriport/metriport-internal#1040 Signed-off-by: Rafael Leite <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref. metriport/metriport-internal#1040
Dependencies
Description
Create ALB version of the API - context.
Next PR will point things to it. The last one will remove the NLB based API.
Testing
executeWithNetworkRetries
is not on base branch yet (develop
)Release Plan