Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1040 - 3/3 Remove NLB based API #2305

Merged
merged 2 commits into from
Jun 20, 2024
Merged

1040 - 3/3 Remove NLB based API #2305

merged 2 commits into from
Jun 20, 2024

Conversation

leite08
Copy link
Member

@leite08 leite08 commented Jun 19, 2024 •
edited

Ref. metriport/metriport-internal#1040

Dependencies

Description

Remove the NLB version of the API's - context

Testing

  • Local
    • cdk diff successful
  • Staging
    • API through API GW works
    • Dash through API GW works
    • ECS restart script leads to near zero errors upon restart of API
      • executeWithNetworkRetries is not on base branch yet (develop)
  • Sandbox
    • none
  • Production
    • none

Release Plan

  • Merge this

@leite08 leite08 changed the title fix(infra): 3/3 remove NLB based API 1040 - 3/3 Remove NLB based API Jun 19, 2024
@leite08 leite08 mentioned this pull request Jun 19, 2024
Merged
5 tasks
@leite08 leite08 marked this pull request as ready for review June 19, 2024 19:56
RamilGaripov
RamilGaripov approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@RamilGaripov RamilGaripov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Base automatically changed from 1040-alb-behind-api-nlb to develop June 20, 2024 03:04
@leite08 leite08 added this pull request to the merge queue Jun 20, 2024
Merged via the queue into develop with commit 0704bcb Jun 20, 2024
7 checks passed
@leite08 leite08 deleted the 1040-alb-behind-api-nlb_2 branch June 20, 2024 03:51
@leite08 leite08 mentioned this pull request Jun 20, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonahkaye jonahkaye jonahkaye approved these changes

@RamilGaripov RamilGaripov RamilGaripov approved these changes

@Goncharo Goncharo Awaiting requested review from Goncharo Goncharo is a code owner

@Orta21 Orta21 Awaiting requested review from Orta21 Orta21 is a code owner

@thomasyopes thomasyopes Awaiting requested review from thomasyopes thomasyopes is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@leite08 @jonahkaye @RamilGaripov