Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(subscriptions): add unbind-from-token message for WebSocket subscriptions #4672

Merged
merged 3 commits into from
Jun 18, 2024

Conversation

ThatOneBro
Copy link
Member

@ThatOneBro ThatOneBro commented Jun 14, 2024

Fixes #4133

@ThatOneBro ThatOneBro added the subscriptions Features and fixes related to subscriptions label Jun 14, 2024
@ThatOneBro ThatOneBro added this to the June 30, 2024 milestone Jun 14, 2024
@ThatOneBro ThatOneBro self-assigned this Jun 14, 2024
@ThatOneBro ThatOneBro requested a review from a team as a code owner June 14, 2024 17:10
Copy link

vercel bot commented Jun 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medplum-provider ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 18, 2024 10:15pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
medplum-app ⬜️ Ignored (Inspect) Visit Preview Jun 18, 2024 10:15pm
medplum-storybook ⬜️ Ignored (Inspect) Visit Preview Jun 18, 2024 10:15pm
medplum-www ⬜️ Ignored (Inspect) Visit Preview Jun 18, 2024 10:15pm

Copy link
Member

@codyebberson codyebberson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, lgtm

Non-blocking, idle thoughts... Would we have any way to track how many open connections there are? Just trying to think through the dev ops scenario, and how we could get observability here. Might already be possible via otel?

packages/mock/src/subscription-manager.ts Outdated Show resolved Hide resolved
@ThatOneBro
Copy link
Member Author

Non-blocking, idle thoughts... Would we have any way to track how many open connections there are? Just trying to think through the dev ops scenario, and how we could get observability here. Might already be possible via otel?

We should definitely add an issue, I think reporting via otel should be relatively simple and would definitely be a win for observability

@ThatOneBro ThatOneBro force-pushed the derrick-add-unbind-from-ws-token branch from 57b4f49 to ed211af Compare June 18, 2024 21:31
@ThatOneBro ThatOneBro force-pushed the derrick-add-unbind-from-ws-token branch from ed211af to 45cf4fc Compare June 18, 2024 21:34
Copy link

sonarcloud bot commented Jun 18, 2024

@ThatOneBro ThatOneBro added this pull request to the merge queue Jun 18, 2024
Merged via the queue into main with commit 085ee77 Jun 18, 2024
32 checks passed
@ThatOneBro ThatOneBro deleted the derrick-add-unbind-from-ws-token branch June 18, 2024 22:23
medplumbot added a commit that referenced this pull request Jun 21, 2024
## What's Changed

fix(ci): fix `\n` missing due to reversal, use `git log --reverse` (#4649)
Allow chained search in _filter (#4647)
Polish eligibility demo (#4637)
cleanup(core): remove stray `console.log` (#4653)
Update sidebar.ts (#4652)
Feat: Configure refresh token expiry (#4525)
Dependency upgrades 2024-06-10 (#4650)
cleanup(chart-demo): rm ignored `example-bots.json` (#4656)
 Adding instructions to the example app READMEs on how to build bots (#4660)
Update useSearch.ts (#4663)
Export QuestionnaireFormContext and QuestionnairePageSequence from QuestionnaireForm (#4664)
Add `expo-polyfills` to README packages list (#4666)
revert(react): remove export of `QuestionnairePageSequence` (#4669)
Fix wrong pipe character in README (#4671)
Document Terminology Service operation endpoints (#4665)
Dependency upgrades 2024-06-17 (#4673)
Gracefully handle no major dep upgrades (#4675)
SQL on FHIR ViewDefinition types (#4674)
fix(build) Update deprecated import assertion into import attribute (#4682)
Fixes #4398 - add mapByIdentifier util function (#4635)
Fixes #4600 - Add Auto Confirmation Parameter for Headless Deployment (#4625)
fix(react-hooks): make `loading` track `MedplumClient#isLoading()` (#4677)
Implements FHIRPath string join (stu) (#4683)
SQL-on-FHIR processResource (#4678)
feat(useSubscription): add `subscriptionProps` as optional param (#4180)
Resolve conditional references (#4633)
feat(subscriptions): add `unbind-from-token` message for WebSocket subscriptions (#4672)
Document remaining Terminology Service operations (#4680)
feat(agent): add `keepAlive` setting to `Agent` (#4657)
Update README.md (#4687)
Fix all copyright dates (#4689)
Fixes subject input on PlanDefinitionApplyForm (#4699)
Deprecate non-strict mode (#4651)
Validate certain references with systemRepo (#4700)
docs(useSubscription): clean up examples, add JSDoc comment (#4692)
cleanup(repo): `handleMaybeCacheOnly` -> `handleStorage` (#4696)
Minor fixes to Eligibility Demo (#4703)

**Full Changelog**: v3.1.8...v3.1.9
github-merge-queue bot pushed a commit that referenced this pull request Jun 22, 2024
## What's Changed

fix(ci): fix `\n` missing due to reversal, use `git log --reverse` (#4649)
Allow chained search in _filter (#4647)
Polish eligibility demo (#4637)
cleanup(core): remove stray `console.log` (#4653)
Update sidebar.ts (#4652)
Feat: Configure refresh token expiry (#4525)
Dependency upgrades 2024-06-10 (#4650)
cleanup(chart-demo): rm ignored `example-bots.json` (#4656)
 Adding instructions to the example app READMEs on how to build bots (#4660)
Update useSearch.ts (#4663)
Export QuestionnaireFormContext and QuestionnairePageSequence from QuestionnaireForm (#4664)
Add `expo-polyfills` to README packages list (#4666)
revert(react): remove export of `QuestionnairePageSequence` (#4669)
Fix wrong pipe character in README (#4671)
Document Terminology Service operation endpoints (#4665)
Dependency upgrades 2024-06-17 (#4673)
Gracefully handle no major dep upgrades (#4675)
SQL on FHIR ViewDefinition types (#4674)
fix(build) Update deprecated import assertion into import attribute (#4682)
Fixes #4398 - add mapByIdentifier util function (#4635)
Fixes #4600 - Add Auto Confirmation Parameter for Headless Deployment (#4625)
fix(react-hooks): make `loading` track `MedplumClient#isLoading()` (#4677)
Implements FHIRPath string join (stu) (#4683)
SQL-on-FHIR processResource (#4678)
feat(useSubscription): add `subscriptionProps` as optional param (#4180)
Resolve conditional references (#4633)
feat(subscriptions): add `unbind-from-token` message for WebSocket subscriptions (#4672)
Document remaining Terminology Service operations (#4680)
feat(agent): add `keepAlive` setting to `Agent` (#4657)
Update README.md (#4687)
Fix all copyright dates (#4689)
Fixes subject input on PlanDefinitionApplyForm (#4699)
Deprecate non-strict mode (#4651)
Validate certain references with systemRepo (#4700)
docs(useSubscription): clean up examples, add JSDoc comment (#4692)
cleanup(repo): `handleMaybeCacheOnly` -> `handleStorage` (#4696)
Minor fixes to Eligibility Demo (#4703)

**Full Changelog**: v3.1.8...v3.1.9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
subscriptions Features and fixes related to subscriptions
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Add unbind-from-token message to FHIR WebSocket Subscription protocol
2 participants