-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate non-strict mode #4651
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general I think this is a good change, but want to get more consensus on this 👍
Curious what motivated this change? In a perfect world, I agree, and we would appeal to maximum strictness all the time. In practice, we have significant customers who depend on non-strict capabilities, so we cannot actually remove it in the immediate future. @rahul1 - do you have any thoughts here? |
@codyebberson The intent was to only deprecate the setting, so that any customers already using the escape hatch still have it. This change would just make it so non-Super Admins cannot turn the feature on anymore, guiding new customers towards the more correct option |
## What's Changed fix(ci): fix `\n` missing due to reversal, use `git log --reverse` (#4649) Allow chained search in _filter (#4647) Polish eligibility demo (#4637) cleanup(core): remove stray `console.log` (#4653) Update sidebar.ts (#4652) Feat: Configure refresh token expiry (#4525) Dependency upgrades 2024-06-10 (#4650) cleanup(chart-demo): rm ignored `example-bots.json` (#4656) Adding instructions to the example app READMEs on how to build bots (#4660) Update useSearch.ts (#4663) Export QuestionnaireFormContext and QuestionnairePageSequence from QuestionnaireForm (#4664) Add `expo-polyfills` to README packages list (#4666) revert(react): remove export of `QuestionnairePageSequence` (#4669) Fix wrong pipe character in README (#4671) Document Terminology Service operation endpoints (#4665) Dependency upgrades 2024-06-17 (#4673) Gracefully handle no major dep upgrades (#4675) SQL on FHIR ViewDefinition types (#4674) fix(build) Update deprecated import assertion into import attribute (#4682) Fixes #4398 - add mapByIdentifier util function (#4635) Fixes #4600 - Add Auto Confirmation Parameter for Headless Deployment (#4625) fix(react-hooks): make `loading` track `MedplumClient#isLoading()` (#4677) Implements FHIRPath string join (stu) (#4683) SQL-on-FHIR processResource (#4678) feat(useSubscription): add `subscriptionProps` as optional param (#4180) Resolve conditional references (#4633) feat(subscriptions): add `unbind-from-token` message for WebSocket subscriptions (#4672) Document remaining Terminology Service operations (#4680) feat(agent): add `keepAlive` setting to `Agent` (#4657) Update README.md (#4687) Fix all copyright dates (#4689) Fixes subject input on PlanDefinitionApplyForm (#4699) Deprecate non-strict mode (#4651) Validate certain references with systemRepo (#4700) docs(useSubscription): clean up examples, add JSDoc comment (#4692) cleanup(repo): `handleMaybeCacheOnly` -> `handleStorage` (#4696) Minor fixes to Eligibility Demo (#4703) **Full Changelog**: v3.1.8...v3.1.9
## What's Changed fix(ci): fix `\n` missing due to reversal, use `git log --reverse` (#4649) Allow chained search in _filter (#4647) Polish eligibility demo (#4637) cleanup(core): remove stray `console.log` (#4653) Update sidebar.ts (#4652) Feat: Configure refresh token expiry (#4525) Dependency upgrades 2024-06-10 (#4650) cleanup(chart-demo): rm ignored `example-bots.json` (#4656) Adding instructions to the example app READMEs on how to build bots (#4660) Update useSearch.ts (#4663) Export QuestionnaireFormContext and QuestionnairePageSequence from QuestionnaireForm (#4664) Add `expo-polyfills` to README packages list (#4666) revert(react): remove export of `QuestionnairePageSequence` (#4669) Fix wrong pipe character in README (#4671) Document Terminology Service operation endpoints (#4665) Dependency upgrades 2024-06-17 (#4673) Gracefully handle no major dep upgrades (#4675) SQL on FHIR ViewDefinition types (#4674) fix(build) Update deprecated import assertion into import attribute (#4682) Fixes #4398 - add mapByIdentifier util function (#4635) Fixes #4600 - Add Auto Confirmation Parameter for Headless Deployment (#4625) fix(react-hooks): make `loading` track `MedplumClient#isLoading()` (#4677) Implements FHIRPath string join (stu) (#4683) SQL-on-FHIR processResource (#4678) feat(useSubscription): add `subscriptionProps` as optional param (#4180) Resolve conditional references (#4633) feat(subscriptions): add `unbind-from-token` message for WebSocket subscriptions (#4672) Document remaining Terminology Service operations (#4680) feat(agent): add `keepAlive` setting to `Agent` (#4657) Update README.md (#4687) Fix all copyright dates (#4689) Fixes subject input on PlanDefinitionApplyForm (#4699) Deprecate non-strict mode (#4651) Validate certain references with systemRepo (#4700) docs(useSubscription): clean up examples, add JSDoc comment (#4692) cleanup(repo): `handleMaybeCacheOnly` -> `handleStorage` (#4696) Minor fixes to Eligibility Demo (#4703) **Full Changelog**: v3.1.8...v3.1.9
No description provided.