Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#9187): fix haproxy version to 2.6.17 - 4.8.x #9190

Merged
merged 2 commits into from
Jun 19, 2024
Merged

fix(#9187): fix haproxy version to 2.6.17 - 4.8.x #9190

merged 2 commits into from
Jun 19, 2024

Conversation

dianabarsan
Copy link
Member

@dianabarsan dianabarsan commented Jun 19, 2024 •
edited by github-actions bot
Loading

Description

Fixes haproxy image to 2.6.17
Skips waiting for deployment complete when upgrading from an old version.

#9187
#9186

Code review checklist

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or e2e where appropriate
  • Internationalised: All user facing text
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

Compose URLs

If Build CI hasn't passed, these may 404:

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

dianabarsan and others added 2 commits June 19, 2024 17:51
@dianabarsan
fix(#9187): fix haproxy version to 2.6.17 (#9188)
6f3ee09 
Haproxy published a new 2.6.18 image today, which breaks one of our unit tests. It might also break behavior.
Fixing the image version to 2.6.17 resolves the issue and makes sure we're having expected behavior.

#9187

(cherry picked from commit 020c3c3)
@dianabarsan
skip waiting for "deployment complete"
a47fef3
Benmuiruri
Benmuiruri approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@Benmuiruri Benmuiruri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this

@dianabarsan dianabarsan merged commit 209d362 into 4.8.x Jun 19, 2024
37 checks passed
@dianabarsan dianabarsan deleted the 9187-4.8.x branch June 19, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Benmuiruri Benmuiruri Benmuiruri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dianabarsan @Benmuiruri