Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin upgrade page incorrectly shows "Error triggering upgrade" even if upgrade was successful #9186

Open
dianabarsan opened this issue Jun 19, 2024 · 1 comment
Open

Admin upgrade page incorrectly shows "Error triggering upgrade" even if upgrade was successful #9186

dianabarsan opened this issue Jun 19, 2024 · 1 comment
Labels
Affects: 4.1.2 Affects: 4.2.4 Affects: 4.3.2 Affects: 4.4.2 Affects: 4.5.2 Type: Bug Fix something that isn't working as intended

Comments

@dianabarsan
Copy link
Member

Describe the bug
This only affects older versions of the CHT installing newer versions, and it's caused by a change in the api/deploy-info interface: #8790

To Reproduce
Steps to reproduce the behavior:

  1. Install 4.2.4
  2. Upgrade to 4.6.0. Wait until upgrade is complete.
  3. Notice that the upgrade page says "Error triggering upgrade" but the version displayed is 4.6.0.

Expected behavior
The upgrade was successful, so the admin page should not report that upgrade was not.

Environment

  • App: admin
  • Version: 4.2.x -> 4.5.0

Additional context
This only affects upgrades from versions lower than 4.6.0 to versions higher than 4.6.0
@dianabarsan
Copy link
Member Author

I've discovered this after adding the upgrade e2e test from 4.2.4 to current, and pushed the first tag. For branches the test works correctly.

This was referenced Jun 19, 2024
Merged
Merged
dianabarsan added a commit that referenced this issue Jun 19, 2024
@dianabarsan
fix(#9187): fix haproxy version to 2.6.17
551abb8 
Fixes haproxy image to 2.6.17
Skips waiting for deployment complete when upgrading from an old version.

#9187
#9186
dianabarsan added a commit that referenced this issue Jun 19, 2024
@dianabarsan
fix(#9187): fix haproxy version to 2.6.17
209d362 
Fixes haproxy image to 2.6.17
Skips waiting for deployment complete when upgrading from an old version.

#9187
#9186
@dianabarsan dianabarsan mentioned this issue Jun 21, 2024
Merged
5 tasks
latin-panda pushed a commit that referenced this issue Jun 22, 2024
@dianabarsan
fix(#9186): skip waiting for deployment complete (#9196)
8ce2fd0
latin-panda pushed a commit that referenced this issue Jul 2, 2024
@dianabarsan @latin-panda
fix(#9187): fix haproxy version to 2.6.17
fa865b3 
Fixes haproxy image to 2.6.17
Skips waiting for deployment complete when upgrading from an old version.

#9187
#9186
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Affects: 4.1.2 Affects: 4.2.4 Affects: 4.3.2 Affects: 4.4.2 Affects: 4.5.2 Type: Bug Fix something that isn't working as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dianabarsan