Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Haproxy unit tests are failing due to haproxy patch release #9187

Closed
dianabarsan opened this issue Jun 19, 2024 · 4 comments
Closed

Haproxy unit tests are failing due to haproxy patch release #9187

dianabarsan opened this issue Jun 19, 2024 · 4 comments
Assignees
@dianabarsan
Labels
Priority: 1 - High Blocks the next release. Type: Technical issue Improve something that users won't notice
Milestone
4.9.0

Comments

@dianabarsan
Copy link
Member

Describe the issue
Haproxy unit tests are failing consistently on release tags:
https://github.com/medic/cht-core/actions/runs/9576953226
https://github.com/medic/cht-core/actions/runs/9576944026

Describe the improvement you'd like
Fix or disable the test.
@dianabarsan dianabarsan added Type: Technical issue Improve something that users won't notice Priority: 1 - High Blocks the next release. labels Jun 19, 2024
@dianabarsan dianabarsan self-assigned this Jun 19, 2024
@dianabarsan
Copy link
Member Author

Looks like this is happening on master as well.

@dianabarsan dianabarsan mentioned this issue Jun 19, 2024
Merged
5 tasks
@dianabarsan
Copy link
Member Author

It turns out this was caused by a new minor of haproxy getting published today (2.6.18) - which has a really long list of changes https://www.haproxy.org/download/2.6/src/CHANGELOG .
As a quick fix to unblock builds, I'm fixing the haproxy image version to 2.16.17, with the intention we investigate what exactly happened, if our test was incorrect and why this behavior has changed in the newer version.

@dianabarsan
Copy link
Member Author

Because this is blocking patch releases, I'm backporting this to 4.7.x and 4.8.x

dianabarsan added a commit that referenced this issue Jun 19, 2024
@dianabarsan
fix(#9187): fix haproxy version to 2.6.17 (#9188)
020c3c3 
Haproxy published a new 2.6.18 image today, which breaks one of our unit tests. It might also break behavior.
Fixing the image version to 2.6.17 resolves the issue and makes sure we're having expected behavior.

#9187
dianabarsan added a commit that referenced this issue Jun 19, 2024
@dianabarsan
fix(#9187): fix haproxy version to 2.6.17 (#9188)
5842470 
Haproxy published a new 2.6.18 image today, which breaks one of our unit tests. It might also break behavior.
Fixing the image version to 2.6.17 resolves the issue and makes sure we're having expected behavior.

#9187

(cherry picked from commit 020c3c3)
dianabarsan added a commit that referenced this issue Jun 19, 2024
@dianabarsan
fix(#9187): fix haproxy version to 2.6.17 (#9188)
6f3ee09 
Haproxy published a new 2.6.18 image today, which breaks one of our unit tests. It might also break behavior.
Fixing the image version to 2.6.17 resolves the issue and makes sure we're having expected behavior.

#9187

(cherry picked from commit 020c3c3)
This was referenced Jun 19, 2024
Merged
Merged
dianabarsan added a commit that referenced this issue Jun 19, 2024
@dianabarsan
fix(#9187): fix haproxy version to 2.6.17
551abb8 
Fixes haproxy image to 2.6.17
Skips waiting for deployment complete when upgrading from an old version.

#9187
#9186
@dianabarsan dianabarsan changed the title Haproxy unit tests are failing on release Haproxy unit tests are failing due to haproxy patch release Jun 19, 2024
dianabarsan added a commit that referenced this issue Jun 19, 2024
@dianabarsan
fix(#9187): fix haproxy version to 2.6.17
209d362 
Fixes haproxy image to 2.6.17
Skips waiting for deployment complete when upgrading from an old version.

#9187
#9186
@dianabarsan
Copy link
Member Author

Merged to master and backported to 4.7.x and 4.8.x

@dianabarsan dianabarsan added this to the 4.9.0 milestone Jun 19, 2024
latin-panda pushed a commit that referenced this issue Jul 2, 2024
@dianabarsan @latin-panda
fix(#9187): fix haproxy version to 2.6.17
fa865b3 
Fixes haproxy image to 2.6.17
Skips waiting for deployment complete when upgrading from an old version.

#9187
#9186
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dianabarsan dianabarsan

Labels
Priority: 1 - High Blocks the next release. Type: Technical issue Improve something that users won't notice
Projects
None yet
Milestone
4.9.0
Development

No branches or pull requests
1 participant
@dianabarsan