Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

[MM-28221] Payment Info Edit/View #6709

Merged
merged 4 commits into from
Oct 13, 2020
Merged

Conversation

devinbinnie
Copy link
Member

Summary

Payment Information View.

We'll just do a developer review now and review UX/QA in a bigger PR later on.

NOTES:

  • Wasn't able to fully test the credit card update, but the billing address was properly update so I'm assuming it works.
  • Remove Payment Info isn't currently implemented, I'm not sure it's needed.

Ticket Link

https://mattermost.atlassian.net/browse/MM-28221

Screenshots

Screen Shot 2020-10-08 at 5 23 17 PM

Screen Shot 2020-10-08 at 5 23 32 PM

@devinbinnie devinbinnie added the 2: Dev Review Requires review by a core commiter label Oct 8, 2020
Copy link
Member

@marianunez marianunez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @devinbinnie! Just a comment below

components/admin_console/billing/payment_info_edit.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@gabrieljackson gabrieljackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@devinbinnie devinbinnie added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Oct 13, 2020
@devinbinnie devinbinnie merged commit e169ec0 into mattermost:master Oct 13, 2020
@marianunez
Copy link
Member

/cherry-pick cloud-ga

@mattermod
Copy link
Contributor

Cherry pick is scheduled.

mattermost-build pushed a commit to mattermost-build/mattermost-webapp that referenced this pull request Oct 13, 2020
* Payment information view

* [MM-28221] Payment Info Edit

* PR feedback and other fixes

(cherry picked from commit e169ec0)
@mattermod mattermod added the CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone label Oct 13, 2020
devinbinnie added a commit that referenced this pull request Oct 13, 2020
* Payment information view

* [MM-28221] Payment Info Edit

* PR feedback and other fixes

(cherry picked from commit e169ec0)

Co-authored-by: Devin Binnie <[email protected]>
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Oct 13, 2020
Tak-Iwamoto pushed a commit to Tak-Iwamoto/mattermost-webapp that referenced this pull request Oct 14, 2020
…o MM-20457

* 'master' of github.com:Tak-Iwamoto/mattermost-webapp: (87 commits)
  MM-T644 Integrations display on team where they were created (mattermost#6752)
  [MM-20478] Migrate post_header module to TypeScript (mattermost#6631)
  [MM-20599] Migrated select_team component to Typescript (mattermost#6574)
  MM-20554 Migrate 'components/delete_post_modal' module and associated tests to TypeScript (mattermost#6656)
  [MM-24436]- Add a threshold from bottom for new messages toast (mattermost#5828)
  [MM-20489] Migrate failed_post_options and its tests to typescript (mattermost#6717)
  [MM-28063] Cloud Telemetry - Admin Console (mattermost#6762)
  [MM-29559][MM-29558] Company Info Fixes (mattermost#6764)
  [MM-29557] [MM-29590] Update subscription when purchase modal closes (mattermost#6765)
  [MM-29615] Fixed subscription page so it doesn't load until subscription info is loaded (mattermost#6766)
  [MM-28064] Add telemetry in various places around cloud message banners (mattermost#6763)
  migrate changeCSS function CSS variable for mobile CSS .tutorial-steps__container selector. (mattermost#6743)
  [MM-27231]: cypress test for MM-T1837 (mattermost#6676)
  [MM-28062] Add telemetry for in-app purchase flow (mattermost#6760)
  MM-27454 - Contact Us and Billing Documentation Links (mattermost#6731)
  [MM-20514] Migrates components/password reset send link to typescript (mattermost#6584)
  Cloud Billing polish Soft GA (mattermost#6740)
  [MM-28221] Payment Info Edit/View (mattermost#6709)
  MM-T636 Description field for incoming and outgoing webhooks can hold 500 characters (mattermost#6682)
  Translations update from Weblate (mattermost#6748)
  ...
jfrerich pushed a commit that referenced this pull request Oct 23, 2020
* Payment information view

* [MM-28221] Payment Info Edit

* PR feedback and other fixes
calebroseland pushed a commit that referenced this pull request Oct 27, 2020
* Payment information view

* [MM-28221] Payment Info Edit

* PR feedback and other fixes
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants