This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
[MM-20514] Migrates components/password reset send link to typescript #6584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates password_reset_send_link snapshot
jgilliam17
approved these changes
Oct 2, 2020
There was a problem hiding this comment.
Thank you @sikloidz
Tested, looks good to merge.
- Verified password reset link functionality - as expected.
|
Test server destroyed |
calebroseland
approved these changes
Oct 6, 2020
| e.preventDefault(); | ||
|
|
||
| const email = this.emailInput.current.value.trim().toLowerCase(); | ||
| const email = this.emailInput.current!.value.trim().toLowerCase(); |
There was a problem hiding this comment.
Suggested change
| const email = this.emailInput.current!.value.trim().toLowerCase(); | |
| const email = this.emailInput.current?.value.trim().toLowerCase(); |
Minor: I think ? would be a bit more appropriate
| @@ -0,0 +1,22 @@ | |||
| // Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved. | |||
| // See LICENSE.txt for license information. | |||
|
|
|||
There was a problem hiding this comment.
Suggested change
| import {ComponentProps} from 'react'; |
Comment on lines
+12
to
+14
| type Actions = { | ||
| sendPasswordResetEmail: (emal: string) => Promise<{data: any; error: ServerError}>; | ||
| } |
There was a problem hiding this comment.
Suggested change
| type Actions = { | |
| sendPasswordResetEmail: (emal: string) => Promise<{data: any; error: ServerError}>; | |
| } | |
| type Actions = ComponentProps<typeof PasswordResetSendLink>['actions']; |
Minor: could be de-duped
| import {connect} from 'react-redux'; | ||
| import {sendPasswordResetEmail} from 'mattermost-redux/actions/users'; | ||
| import {GenericAction, ActionFunc} from 'mattermost-redux/types/actions'; | ||
| import {ServerError} from 'mattermost-redux/types/errors'; |
There was a problem hiding this comment.
Suggested change
| import {ServerError} from 'mattermost-redux/types/errors'; |
components/password_reset_send_link/password_reset_send_link.tsx
Outdated
Show resolved
Hide resolved
|
@sikloidz Just want to touch bases and check if you have any questions about the feedback above? |
|
/update-branch |
|
@hanzei I think we can just merge as-is. |
|
@calebroseland Are you fine with merging this as it is? |
|
@hanzei as-is is fine, they were just small, non-blocking suggestions. |
Co-authored-by: Caleb Roseland <[email protected]>
|
Thank you for the contribution @sikloidz 👍 |
Tak-Iwamoto
pushed a commit
to Tak-Iwamoto/mattermost-webapp
that referenced
this pull request
Oct 14, 2020
…o MM-20457 * 'master' of github.com:Tak-Iwamoto/mattermost-webapp: (87 commits) MM-T644 Integrations display on team where they were created (mattermost#6752) [MM-20478] Migrate post_header module to TypeScript (mattermost#6631) [MM-20599] Migrated select_team component to Typescript (mattermost#6574) MM-20554 Migrate 'components/delete_post_modal' module and associated tests to TypeScript (mattermost#6656) [MM-24436]- Add a threshold from bottom for new messages toast (mattermost#5828) [MM-20489] Migrate failed_post_options and its tests to typescript (mattermost#6717) [MM-28063] Cloud Telemetry - Admin Console (mattermost#6762) [MM-29559][MM-29558] Company Info Fixes (mattermost#6764) [MM-29557] [MM-29590] Update subscription when purchase modal closes (mattermost#6765) [MM-29615] Fixed subscription page so it doesn't load until subscription info is loaded (mattermost#6766) [MM-28064] Add telemetry in various places around cloud message banners (mattermost#6763) migrate changeCSS function CSS variable for mobile CSS .tutorial-steps__container selector. (mattermost#6743) [MM-27231]: cypress test for MM-T1837 (mattermost#6676) [MM-28062] Add telemetry for in-app purchase flow (mattermost#6760) MM-27454 - Contact Us and Billing Documentation Links (mattermost#6731) [MM-20514] Migrates components/password reset send link to typescript (mattermost#6584) Cloud Billing polish Soft GA (mattermost#6740) [MM-28221] Payment Info Edit/View (mattermost#6709) MM-T636 Description field for incoming and outgoing webhooks can hold 500 characters (mattermost#6682) Translations update from Weblate (mattermost#6748) ...
jfrerich
pushed a commit
that referenced
this pull request
Oct 23, 2020
…#6584) Co-authored-by: Caleb Roseland <[email protected]> Co-authored-by: Ben Schumacher <[email protected]>
calebroseland
added a commit
that referenced
this pull request
Oct 27, 2020
…#6584) Co-authored-by: Caleb Roseland <[email protected]> Co-authored-by: Ben Schumacher <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrates files under
componentes/password_reset_send_linkto typescriptTicket Link
Fixes mattermost/mattermost#13726