Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-20554 Migrate 'components/delete_post_modal' module and associated tests to TypeScript #6656

Merged
merged 4 commits into from
Oct 14, 2020

Conversation

anchepiece
Copy link
Contributor

Summary

This pull request migrates 'components/delete_post_modal' to TypeScript.
All tests pass locally, suggestions on improvement welcome.

Ticket Link

Fixes mattermost/mattermost#13687
JIRA https://mattermost.atlassian.net/browse/MM-20554

@mattermod
Copy link
Contributor

Hello @anchepiece,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@jfrerich jfrerich added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester hacktoberfest-accepted labels Oct 6, 2020
Copy link
Member

@devinbinnie devinbinnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anchepiece! Just a few comments to resolve.

components/delete_post_modal/delete_post_modal.tsx Outdated Show resolved Hide resolved
components/delete_post_modal/delete_post_modal.tsx Outdated Show resolved Hide resolved
components/delete_post_modal/index.ts Outdated Show resolved Hide resolved
Copy link
Member

@devinbinnie devinbinnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @anchepiece!

Copy link
Member

@hmhealey hmhealey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping with this migration. Looks good to me!

@hmhealey hmhealey added Setup Cloud Test Server Setup a test server using Mattermost Cloud and removed 2: Dev Review Requires review by a core commiter labels Oct 8, 2020
@hanzei
Copy link
Contributor

hanzei commented Oct 13, 2020

/update-branch

Copy link
Contributor

@stevemudie stevemudie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevemudie stevemudie added QA Review Done and removed 3: QA Review Requires review by a QA tester labels Oct 13, 2020
@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed QA Review Done labels Oct 14, 2020
@hanzei hanzei added this to the v5.30.0 milestone Oct 14, 2020
@hanzei hanzei merged commit 8aa0628 into mattermost:master Oct 14, 2020
@mattermod mattermod removed the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Oct 14, 2020
@mm-cloud-bot
Copy link

Test server destroyed

1 similar comment
@mm-cloud-bot
Copy link

Test server destroyed

Tak-Iwamoto pushed a commit to Tak-Iwamoto/mattermost-webapp that referenced this pull request Oct 14, 2020
…o MM-20457

* 'master' of github.com:Tak-Iwamoto/mattermost-webapp: (87 commits)
  MM-T644 Integrations display on team where they were created (mattermost#6752)
  [MM-20478] Migrate post_header module to TypeScript (mattermost#6631)
  [MM-20599] Migrated select_team component to Typescript (mattermost#6574)
  MM-20554 Migrate 'components/delete_post_modal' module and associated tests to TypeScript (mattermost#6656)
  [MM-24436]- Add a threshold from bottom for new messages toast (mattermost#5828)
  [MM-20489] Migrate failed_post_options and its tests to typescript (mattermost#6717)
  [MM-28063] Cloud Telemetry - Admin Console (mattermost#6762)
  [MM-29559][MM-29558] Company Info Fixes (mattermost#6764)
  [MM-29557] [MM-29590] Update subscription when purchase modal closes (mattermost#6765)
  [MM-29615] Fixed subscription page so it doesn't load until subscription info is loaded (mattermost#6766)
  [MM-28064] Add telemetry in various places around cloud message banners (mattermost#6763)
  migrate changeCSS function CSS variable for mobile CSS .tutorial-steps__container selector. (mattermost#6743)
  [MM-27231]: cypress test for MM-T1837 (mattermost#6676)
  [MM-28062] Add telemetry for in-app purchase flow (mattermost#6760)
  MM-27454 - Contact Us and Billing Documentation Links (mattermost#6731)
  [MM-20514] Migrates components/password reset send link to typescript (mattermost#6584)
  Cloud Billing polish Soft GA (mattermost#6740)
  [MM-28221] Payment Info Edit/View (mattermost#6709)
  MM-T636 Description field for incoming and outgoing webhooks can hold 500 characters (mattermost#6682)
  Translations update from Weblate (mattermost#6748)
  ...
@amyblais amyblais added the Changelog/Not Needed Does not require a changelog entry label Oct 14, 2020
@amyblais amyblais added the Docs/Not Needed Does not require documentation label Oct 14, 2020
@anchepiece anchepiece deleted the MM-20554 branch October 15, 2020 18:41
jfrerich pushed a commit that referenced this pull request Oct 23, 2020
calebroseland pushed a commit that referenced this pull request Oct 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Hacktoberfest hacktoberfest-accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate 'components/delete_post_modal' module and associated tests to TypeScript
9 participants