This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
PLT-8352 Handle getting user updated event for logged in user #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwilander
commented
Jan 2, 2018
| if (user.update_at > currentUser.update_at) { | ||
| // Need to request me to make sure we don't override with sanitized fields from the | ||
| // websocket event | ||
| getMe()(dispatch, getState); |
There was a problem hiding this comment.
The user sent by the WS event will have sanitized fields, but it's difficult to tell what is sanitized and what is actually blank. Easiest solution I could think of was to just request yourself again if the update_at for the WS provided user is newer. This will prevent the client making the update request from making this request but other tabs/clients will make it.
grundleborg
approved these changes
Jan 2, 2018
crspeller
approved these changes
Jan 2, 2018
jasonblais
added
Changelog/Done
hmhealey
pushed a commit
that referenced
this pull request
Aug 28, 2020
* MM-10776: Adds support for new API endpoint to update team or channel member scheme roles. (#521) * Disable fetch calls when offline (#522) * Disable fetch calls when offline * Move online check to doFetchWithResponse * fix permission error on channel_converted event (in used by mobile RN) (#523) * warn about dropping backwards compatibility just once (#525) * Safely trying to instantiate Set. (#527) * Safely trying to instantiate Set. * Added warning * Removes console.warn.
hmhealey
pushed a commit
that referenced
this pull request
Mar 17, 2021
* Safely trying to instantiate Set. * Added warning
hmhealey
pushed a commit
that referenced
this pull request
Mar 17, 2021
* MM-10776: Adds support for new API endpoint to update team or channel member scheme roles. (#521) * Disable fetch calls when offline (#522) * Disable fetch calls when offline * Move online check to doFetchWithResponse * fix permission error on channel_converted event (in used by mobile RN) (#523) * warn about dropping backwards compatibility just once (#525) * Safely trying to instantiate Set. (#527) * Safely trying to instantiate Set. * Added warning * Removes console.warn.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Handle getting user updated event for logged in user by requesting self if update_at is newer than the one we have.
Ticket Link
Web app portion of https://mattermost.atlassian.net/browse/PLT-8352
Checklist
make check-styleto check for style errors (required for all pull requests)make testto ensure unit and component tests passed