Relese5.0 merge master 20180611 (#529)

* MM-10776: Adds support for new API endpoint to update team or channel member scheme roles. (#521)

* Disable fetch calls when offline (#522)

* Disable fetch calls when offline

* Move online check to doFetchWithResponse

* fix permission error on channel_converted event (in used by mobile RN) (#523)

* warn about dropping backwards compatibility just once (#525)

* Safely trying to instantiate Set. (#527)

* Safely trying to instantiate Set.

* Added warning

* Removes console.warn.

packages/mattermost-redux/src/actions/roles.js

@@ -60,7 +60,12 @@ export function setPendingRoles(roles) {
 export function loadRolesIfNeeded(roles) {
  return async (dispatch, getState) => {
  const state = getState();
- const pendingRoles = new Set(state.entities.roles.pending);
+ let pendingRoles = new Set();
+ try {
+ pendingRoles = new Set(state.entities.roles.pending);
+ } catch (e) {
+ // eslint-disable-line
+ }
  for (const role of roles) {
  pendingRoles.add(role);
  }

packages/mattermost-redux/src/store/initial_state.js

@@ -96,7 +96,7 @@ const state: GlobalState = {
  typing: {},
  roles: {
  roles: {},
- pending: [],
+ pending: new Set(),
  },
  schemes: {schemes: {}},
  },

packages/mattermost-redux/src/utils/helpers.js

@@ -74,9 +74,16 @@ export const isMinimumServerVersion = (currentVersion, minMajorVersion = 0, minM
  // Dot version is equal
  return true;
 };
+
+let sentMessageToRemoveBackwardsCompatibility = false;
 export const sendMessageToRemoveBackwardsCompatibility = (currentVersion, minVersion) => {
  if (process.env.NODE_ENV !== 'production' && currentVersion > minVersion) { //eslint-disable-line no-process-env
+ if (sentMessageToRemoveBackwardsCompatibility) {
+ return;
+ }
+
  console.warn('You can now remove backwards-compatibility code from the project, as referenced in the stacktrace below.'); //eslint-disable-line no-console
+ sentMessageToRemoveBackwardsCompatibility = true;
  }
 };