This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
GH-7782: Migrate channel_members_modal.jsx to be pure and use Redux #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grundleborg
added
1: PM Review
jwilander
approved these changes
Jan 2, 2018
saturninoabril
changed the title
saturninoabril
approved these changes
Jan 2, 2018
jasonblais
added
Changelog/Not Needed
hmhealey
pushed a commit
that referenced
this pull request
Aug 28, 2020
* MM-10776: Adds support for new API endpoint to update team or channel member scheme roles. (#521) * Disable fetch calls when offline (#522) * Disable fetch calls when offline * Move online check to doFetchWithResponse * fix permission error on channel_converted event (in used by mobile RN) (#523) * warn about dropping backwards compatibility just once (#525) * Safely trying to instantiate Set. (#527) * Safely trying to instantiate Set. * Added warning * Removes console.warn.
hmhealey
pushed a commit
that referenced
this pull request
Mar 17, 2021
… member scheme roles. (#521)
hmhealey
pushed a commit
that referenced
this pull request
Mar 17, 2021
* MM-10776: Adds support for new API endpoint to update team or channel member scheme roles. (#521) * Disable fetch calls when offline (#522) * Disable fetch calls when offline * Move online check to doFetchWithResponse * fix permission error on channel_converted event (in used by mobile RN) (#523) * warn about dropping backwards compatibility just once (#525) * Safely trying to instantiate Set. (#527) * Safely trying to instantiate Set. * Added warning * Removes console.warn.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactor channel_members_modal.jsx to use redux
Ticket Link
mattermost/mattermost#7782
Checklist
make check-styleto check for style errorsmake testto ensure unit and component tests passedenv: jestfromeslintwithout b8f85e9