Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

[MM-19441] Fix the case of redirecting to an unavailable channel #4070

Merged
merged 1 commit into from
Oct 30, 2019
Merged

[MM-19441] Fix the case of redirecting to an unavailable channel #4070

merged 1 commit into from
Oct 30, 2019

Conversation

mgdelacroix
Copy link
Member

Summary

This PR adds a check to prevent the redirectUserToDefaultTeam from redirecting the user to a channel that they have been just removed from.

Ticket Link

https://mattermost.atlassian.net/browse/MM-19441

@mgdelacroix mgdelacroix added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Oct 27, 2019
@mgdelacroix mgdelacroix added this to the v5.17.0 milestone Oct 27, 2019
@mgdelacroix mgdelacroix requested review from srkgupta, sudheerDev and a team October 27, 2019 21:09
@ghost ghost requested review from mkraft and removed request for a team October 27, 2019 21:09
@amyblais amyblais added the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Oct 28, 2019
@sudheerDev sudheerDev removed the 2: Dev Review Requires review by a core commiter label Oct 29, 2019
@srkgupta srkgupta added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Oct 30, 2019
srkgupta
srkgupta approved these changes Oct 30, 2019
View reviewed changes
Copy link
Contributor

@srkgupta srkgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on the PR instance and the issue is working fine.

@srkgupta srkgupta added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester Setup Cloud Test Server Setup a test server using Mattermost Cloud labels Oct 30, 2019
@mattermod
Copy link
Contributor

Test server destroyed

@srkgupta srkgupta merged commit 70ef7ca into mattermost:master Oct 30, 2019
@mattermost-build mattermost-build mentioned this pull request Oct 30, 2019
Merged
@mattermod mattermod added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Oct 30, 2019
iwataka added a commit to iwataka/mattermost-webapp that referenced this pull request Oct 30, 2019
@iwataka
Merge remote-tracking branch 'upstream/master' into MM-18707_automate…
7965183 
…d-ui-testing-for-channel-reference-autocompletion

* upstream/master: (58 commits)
  MM-18541 - Updating header description css (mattermost#4048)
  [MM-19441] Fix the case of redirecting to an unavailable channel (mattermost#4070)
  [GH-12954] Migrate 'components/admin_console/color_setting.jsx' and associated tests to TypeScript (mattermost#4080)
  MM-18910 Migrate utils/emoticons to typescript (mattermost#3853)
  Mm 12447 Migrate 'components/get_link_modal.jsx' and associated tests to TypeScript (mattermost#3954)
  MM 17278 - Stop posts lists from scrolling when the emoji picker is open (mattermost#3860)
  MM-18157 - added loading screen to members modal (mattermost#3725)
  MM-19017 - Updating markdown images (mattermost#4047)
  MM-18956: error_pages components and tests to TS (mattermost#4050)
  Request team from API if invite_id is missing (mattermost#4072)
  MM-19678 - Restored setSelected in MultiSelectList component (mattermost#4033)
  [GH-12956] Migrate 'components/admin_console/banner.jsx' to TypeScript (mattermost#4075)
  [GH-12955] Migrate 'components/admin_console/highlight.jsx' to TypeScript (mattermost#4076)
  Change erroneous role='icon' to role='img' (mattermost#4051)
  [MM-18989] Migrate 'components/save_button.jsx' and associated tests to TypeScript (mattermost#4046)
  correct the height of the team sidebar when there's an announcement (mattermost#4073)
  Publishing storybook using circle-ci (mattermost#4037)
  [MM-18988] Migrate components/recent_date to TypeScript (mattermost#3883)
  MM-18629 - Remove default value for radio elements in interacti… (mattermost#4059)
  Replaced functionality in deprecated lifecycle methods (mattermost#3947)
  ...
@mgdelacroix mgdelacroix deleted the mm-19441 branch October 30, 2019 14:28
ashishmahi pushed a commit to ashishmahi/mattermost-webapp that referenced this pull request Oct 30, 2019
@mgdelacroix @ashishmahi
[MM-19441] Fix the case of redirecting to an unavailable channel (mat…
a137ed0 
…termost#4070)
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Oct 30, 2019
brewsterbhg pushed a commit to brewsterbhg/mattermost-webapp that referenced this pull request Nov 11, 2019
@mgdelacroix @brewsterbhg
[MM-19441] Fix the case of redirecting to an unavailable channel (mat…
41936a3 
…termost#4070)
@srkgupta srkgupta added the Tests/Done Release tests have been written label Nov 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mkraft mkraft mkraft approved these changes

@srkgupta srkgupta srkgupta approved these changes

@sudheerDev sudheerDev sudheerDev approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation QA Review Done Tests/Done Release tests have been written
Projects
None yet
Milestone
v5.17.0
6 participants
@mgdelacroix @mattermod @mkraft @srkgupta @sudheerDev @amyblais