This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-18157 - added loading screen to members modal #3725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanzei
added
2: Dev Review
bradjcoughlin
suggested changes
Sep 23, 2019
bradjcoughlin
approved these changes
Sep 27, 2019
sbishel
approved these changes
Oct 1, 2019
|
This issue has been automatically labelled "stale" because it hasn't had recent activity. /cc @jasonblais @hanzei |
saturninoabril
suggested changes
Oct 18, 2019
| @@ -9,7 +9,7 @@ import * as UserAgent from 'utils/user_agent.jsx'; | |||
|
|
|||
| import ChannelMembersDropdown from 'components/channel_members_dropdown'; | |||
| import SearchableUserList from 'components/searchable_user_list/searchable_user_list_container.jsx'; | |||
|
|
|||
| import LoadingScreen from 'components/loading_screen.jsx'; | |||
There was a problem hiding this comment.
Suggested change
| import LoadingScreen from 'components/loading_screen.jsx'; | |
| import LoadingScreen from 'components/loading_screen'; |
This component was recently migrated to typescript.
|
This issue has been automatically labelled "stale" because it hasn't had recent activity. /cc @jasonblais @hanzei |
|
Hi @jordeguevara, huge thanks for your contribution! Looks like this just needs a small change to the import, and a sync against Let me know if you have any questions! |
stevemudie
approved these changes
Oct 29, 2019
stevemudie
added
QA Review Done
and removed
3: QA Review
hanzei
added
Do Not Merge
saturninoabril
approved these changes
Oct 30, 2019
saturninoabril
added
the
4: Reviews Complete
iwataka
added a commit
to iwataka/mattermost-webapp
that referenced
this pull request
Oct 30, 2019
…d-ui-testing-for-channel-reference-autocompletion * upstream/master: (58 commits) MM-18541 - Updating header description css (mattermost#4048) [MM-19441] Fix the case of redirecting to an unavailable channel (mattermost#4070) [GH-12954] Migrate 'components/admin_console/color_setting.jsx' and associated tests to TypeScript (mattermost#4080) MM-18910 Migrate utils/emoticons to typescript (mattermost#3853) Mm 12447 Migrate 'components/get_link_modal.jsx' and associated tests to TypeScript (mattermost#3954) MM 17278 - Stop posts lists from scrolling when the emoji picker is open (mattermost#3860) MM-18157 - added loading screen to members modal (mattermost#3725) MM-19017 - Updating markdown images (mattermost#4047) MM-18956: error_pages components and tests to TS (mattermost#4050) Request team from API if invite_id is missing (mattermost#4072) MM-19678 - Restored setSelected in MultiSelectList component (mattermost#4033) [GH-12956] Migrate 'components/admin_console/banner.jsx' to TypeScript (mattermost#4075) [GH-12955] Migrate 'components/admin_console/highlight.jsx' to TypeScript (mattermost#4076) Change erroneous role='icon' to role='img' (mattermost#4051) [MM-18989] Migrate 'components/save_button.jsx' and associated tests to TypeScript (mattermost#4046) correct the height of the team sidebar when there's an announcement (mattermost#4073) Publishing storybook using circle-ci (mattermost#4037) [MM-18988] Migrate components/recent_date to TypeScript (mattermost#3883) MM-18629 - Remove default value for radio elements in interacti… (mattermost#4059) Replaced functionality in deprecated lifecycle methods (mattermost#3947) ...
ashishmahi
pushed a commit
to ashishmahi/mattermost-webapp
that referenced
this pull request
Oct 30, 2019
* added loading screen to members modal * removed div * Fix import
brewsterbhg
pushed a commit
to brewsterbhg/mattermost-webapp
that referenced
this pull request
Nov 11, 2019
* added loading screen to members modal * removed div * Fix import
amyblais
added
Changelog/Not Needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request addresses the issue that 'no users found' is displayed when a user goes to a channel's 'manage member' modal. It now will display a 'Loading. . .' while it is loading and only display original text if after loading there are 'no users found'
Ticket Link
Jira Ticket
Fixes mattermost/mattermost#12241
Related Pull Requests