This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
Change erroneous role='icon' to role='img' #4051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinbinnie
added
2: Dev Review
ghost
requested review from
asaadmahmood
approved these changes
Oct 25, 2019
bradjcoughlin
approved these changes
Oct 25, 2019
lindy65
added
Setup Cloud Test Server
|
Test server destroyed |
lindy65
approved these changes
Oct 28, 2019
There was a problem hiding this comment.
Thanks @devinbinnie - as discussed via DM, this is good from QA side.
devinbinnie
added
the
4: Reviews Complete
iwataka
added a commit
to iwataka/mattermost-webapp
that referenced
this pull request
Oct 30, 2019
…d-ui-testing-for-channel-reference-autocompletion * upstream/master: (58 commits) MM-18541 - Updating header description css (mattermost#4048) [MM-19441] Fix the case of redirecting to an unavailable channel (mattermost#4070) [GH-12954] Migrate 'components/admin_console/color_setting.jsx' and associated tests to TypeScript (mattermost#4080) MM-18910 Migrate utils/emoticons to typescript (mattermost#3853) Mm 12447 Migrate 'components/get_link_modal.jsx' and associated tests to TypeScript (mattermost#3954) MM 17278 - Stop posts lists from scrolling when the emoji picker is open (mattermost#3860) MM-18157 - added loading screen to members modal (mattermost#3725) MM-19017 - Updating markdown images (mattermost#4047) MM-18956: error_pages components and tests to TS (mattermost#4050) Request team from API if invite_id is missing (mattermost#4072) MM-19678 - Restored setSelected in MultiSelectList component (mattermost#4033) [GH-12956] Migrate 'components/admin_console/banner.jsx' to TypeScript (mattermost#4075) [GH-12955] Migrate 'components/admin_console/highlight.jsx' to TypeScript (mattermost#4076) Change erroneous role='icon' to role='img' (mattermost#4051) [MM-18989] Migrate 'components/save_button.jsx' and associated tests to TypeScript (mattermost#4046) correct the height of the team sidebar when there's an announcement (mattermost#4073) Publishing storybook using circle-ci (mattermost#4037) [MM-18988] Migrate components/recent_date to TypeScript (mattermost#3883) MM-18629 - Remove default value for radio elements in interacti… (mattermost#4059) Replaced functionality in deprecated lifecycle methods (mattermost#3947) ...
ashishmahi
pushed a commit
to ashishmahi/mattermost-webapp
that referenced
this pull request
Oct 30, 2019
* Change erroneous role='icon' to role='img' * Test fix
brewsterbhg
pushed a commit
to brewsterbhg/mattermost-webapp
that referenced
this pull request
Nov 11, 2019
* Change erroneous role='icon' to role='img' * Test fix
amyblais
added
Changelog/Not Needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
role='icon'was proposed in a version of ARIA back in 2015, but was never implemented. This PR changes all uses torole='img'. Done for WCAG, found during aXe investigation.Ticket Link
https://mattermost.atlassian.net/browse/MM-19590