This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
[GH-12018] Remove the now unnecessary show prop from PopoverBar #3602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove show prop and related logic from PopoverBar component * Remove reference to this prop from ViewImageModal component * Update PopoverBar's Jest snapshots As noted in issue mattermost#12018, this prop was required earlier to conditionally show/hide the component on mouse enter/leave on modal. But now the component set to permanently show directly via CSS, which makes the prop unnecessary and obsolete.
* Rename the prop as `showCloseBtn` * Update its references in unit tests * Update Jest snapshops for ViewImageModal Now that the PopoverBar's `show` prop has been removed, the showFooter state needs to be renamed as `showCloseBtn` to better reflect its renewed purpose.
hanzei
added
2: Dev Review
ghost
requested review from
hmhealey
approved these changes
Sep 9, 2019
|
@hmhealey Thanks for approving. Cannot wait to see my first PR merged :) |
imisshtml
reviewed
Sep 10, 2019
|
@imisshtml Thanks for your time. Did you get a chance to finish your review? |
@anuragbhd Sorry, I've been having some issues on testing this (my environment, not your code!) so I'm working with the team now to have a test performed. |
|
Just tested this locally, and it looks good to me. @anuragbhd Would you be able to update this branch off the latest master so we can double check everything before it gets merged? |
@imisshtml, @hmhealey - All being good, shall we merge and close this PR? |
|
@anuragbhd Instead of rebasing and force-pushing, you can pull the latest version of master and merge it into your branch. We've got a bit of a guide for that here. I merged it in though so assuming the build passes, we should be good to merge this |
hmhealey
added
4: Reviews Complete
amyblais
added
Changelog/Not Needed
jwilander
pushed a commit
that referenced
this pull request
Sep 24, 2019
* Remove `show` prop from PopoverBar component * Remove show prop and related logic from PopoverBar component * Remove reference to this prop from ViewImageModal component * Update PopoverBar's Jest snapshots As noted in issue #12018, this prop was required earlier to conditionally show/hide the component on mouse enter/leave on modal. But now the component set to permanently show directly via CSS, which makes the prop unnecessary and obsolete. * Rename `showFooter` state in ViewImageModal * Rename the prop as `showCloseBtn` * Update its references in unit tests * Update Jest snapshops for ViewImageModal Now that the PopoverBar's `show` prop has been removed, the showFooter state needs to be renamed as `showCloseBtn` to better reflect its renewed purpose.
lindy65
added
Tests/Not Needed
skheria
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this pull request
Oct 3, 2019
…rBar (mattermost#3602) * Remove `show` prop from PopoverBar component * Remove show prop and related logic from PopoverBar component * Remove reference to this prop from ViewImageModal component * Update PopoverBar's Jest snapshots As noted in issue mattermost#12018, this prop was required earlier to conditionally show/hide the component on mouse enter/leave on modal. But now the component set to permanently show directly via CSS, which makes the prop unnecessary and obsolete. * Rename `showFooter` state in ViewImageModal * Rename the prop as `showCloseBtn` * Update its references in unit tests * Update Jest snapshops for ViewImageModal Now that the PopoverBar's `show` prop has been removed, the showFooter state needs to be renamed as `showCloseBtn` to better reflect its renewed purpose.
skheria
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this pull request
Oct 3, 2019
…rBar (mattermost#3602) * Remove `show` prop from PopoverBar component * Remove show prop and related logic from PopoverBar component * Remove reference to this prop from ViewImageModal component * Update PopoverBar's Jest snapshots As noted in issue mattermost#12018, this prop was required earlier to conditionally show/hide the component on mouse enter/leave on modal. But now the component set to permanently show directly via CSS, which makes the prop unnecessary and obsolete. * Rename `showFooter` state in ViewImageModal * Rename the prop as `showCloseBtn` * Update its references in unit tests * Update Jest snapshops for ViewImageModal Now that the PopoverBar's `show` prop has been removed, the showFooter state needs to be renamed as `showCloseBtn` to better reflect its renewed purpose.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The PopoverBar component is the bottom black bar that we see on an uploaded image's preview modal. Screenshot:
Previously, its
showprop was used to conditionally show/hide the component on mouse enter/leave on modal. But now the component is set to permanently show directly via CSS, which makes the prop unnecessary and obsolete.This PR:
removes the show prop from PopoverBar and its references from the component's parent ViewImageModal
updates unit tests and Jest snapshots accordingly
Ticket Link
Fixes mattermost/mattermost#12018