Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

[GH-12018] Remove the now unnecessary show prop from PopoverBar #3602

Merged
merged 3 commits into from
Sep 16, 2019

Commits on Sep 6, 2019

  1. Remove show prop from PopoverBar component

    * Remove show prop and related logic from PopoverBar component
    
    * Remove reference to this prop from ViewImageModal component
    
    * Update PopoverBar's Jest snapshots
    
    As noted in issue mattermost#12018, this prop was required earlier to
    conditionally show/hide the component on mouse enter/leave on modal.
    
    But now the component set to permanently show directly via CSS,
    which makes the prop unnecessary and obsolete.
    anu-rock committed Sep 6, 2019
    Configuration menu
    Copy the full SHA
    4ca170d View commit details
    Browse the repository at this point in the history
  2. Rename showFooter state in ViewImageModal

    * Rename the prop as `showCloseBtn`
    
    * Update its references in unit tests
    
    * Update Jest snapshops for ViewImageModal
    
    Now that the PopoverBar's `show` prop has been removed, the showFooter
    state needs to be renamed as `showCloseBtn` to better reflect its
    renewed purpose.
    anu-rock committed Sep 6, 2019
    Configuration menu
    Copy the full SHA
    362b269 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2019

  1. Configuration menu
    Copy the full SHA
    636930e View commit details
    Browse the repository at this point in the history