Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the show prop from the PopoverBar component #12018

Closed
mattermod opened this issue Aug 30, 2019 · 2 comments · Fixed by mattermost/mattermost-webapp#3602
Closed

Remove the show prop from the PopoverBar component #12018

mattermod opened this issue Aug 30, 2019 · 2 comments · Fixed by mattermost/mattermost-webapp#3602
Assignees

Comments

@mattermod
Copy link
Contributor

mattermod commented Aug 30, 2019

The PopoverBar component is the bar at the bottom of a file preview that contains the Download and Get Public Link links for an uploaded file attachment
Screen Shot 2019-08-20 at 9 48 04 AM
It used to only be visible when mousing over the modal, but that behaviour was removed by modifying the CSS, but the show prop that controls this was left over.

That prop should be removed, and the tests should be updated to fully reflect the new behaviour.


If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

JIRA: https://mattermost.atlassian.net/browse/MM-12102

@anu-rock
Copy link

anu-rock commented Sep 6, 2019

As a first-time contributor, I am interested in fixing this and currently looking at the code for the same.

@anu-rock
Copy link

anu-rock commented Sep 6, 2019

Submitted my PR here: mattermost/mattermost-webapp#3602 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants