This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-13960 Re-add support for combined user activity posts #2465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwilander
approved these changes
Mar 8, 2019
There was a problem hiding this comment.
This looks really good 👍 I particularly like moving the isFirstReply, consecutivePostByUser, etc. complexity out of the post list and down into the connectors for the posts themselves. Splitting out the message below indicator into it's own component is also nice.
saturninoabril
approved these changes
Mar 11, 2019
| expect(countUnreadsBelow(state, postIds, 500)).toBe(2); | ||
| expect(countUnreadsBelow(state, postIds, 2500)).toBe(1); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Nice to see tests for index.js, looking forward to see more of this.
hmhealey
added a commit
that referenced
this pull request
Apr 3, 2019
* Add unit tests for PostList * Remove unnecessary null check * MM-13960 Re-add support for combined user activity posts * Fix being deleted combined posts not disappearing for the user who deletes the post * Fix PostList unit tests * Fix New Messages Below indicator when PostList takes post IDs * Update mattermost-redux * Update mattermost-redux
hmhealey
added a commit
that referenced
this pull request
Apr 15, 2019
) * MM-13957 Reorganize post actions (#2343) * MM-13957 Reorganize post actions * Use postDeleted action creator * Show join/leave messages since combined systed messages have been temporarily removed * Re-add tests for showFlaggedPosts and showPinnedPosts * Add temporary fix for permalink view * Update mattermost-redux * MM-13958/MM-13959 Make postsInChannel into a sparse array (#2411) * MM-13958/MM-13959 Make postsInChannel into a sparse array * Fix unit tests * Fix being unable to load channels with between 30 and 60 posts * Fix unit tests * MM-13960 Re-add support for combined user activity posts (#2465) * Add unit tests for PostList * Remove unnecessary null check * MM-13960 Re-add support for combined user activity posts * Fix being deleted combined posts not disappearing for the user who deletes the post * Fix PostList unit tests * Fix New Messages Below indicator when PostList takes post IDs * Update mattermost-redux * Update mattermost-redux
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The big change here is that the PostList in the web app will now take an array of post IDs instead of an array of posts, just like the mobile app. Because of this, it can use the same
preparePostIdsForPostListlogic as the mobile app for adding date headers and now also combining system posts. After passing the post ID to a Post or a CombinedUserActivityPost, it will either get or construct a post object and then pass it further down the component tree.Mobile PR: mattermost/mattermost-mobile#2637
Redux PR: mattermost/mattermost-redux#789
Ticket Link
https://mattermost.atlassian.net/browse/MM-13960
Checklist