This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-13958/MM-13959 Make postsInChannel into a sparse array #2411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmhealey
added
the
Do Not Merge/Awaiting PR
hmhealey
added
2: Dev Review
hmhealey
added
the
Do Not Merge/Awaiting PR
saturninoabril
approved these changes
Feb 26, 2019
hmhealey
removed
the
Do Not Merge/Awaiting PR
deanwhillier
approved these changes
Mar 7, 2019
deanwhillier
added
4: Reviews Complete
amyblais
added
Changelog/Not Needed
hmhealey
added a commit
that referenced
this pull request
Apr 3, 2019
lindy65
removed
the
4: Reviews Complete
hmhealey
added a commit
that referenced
this pull request
Apr 15, 2019
) * MM-13957 Reorganize post actions (#2343) * MM-13957 Reorganize post actions * Use postDeleted action creator * Show join/leave messages since combined systed messages have been temporarily removed * Re-add tests for showFlaggedPosts and showPinnedPosts * Add temporary fix for permalink view * Update mattermost-redux * MM-13958/MM-13959 Make postsInChannel into a sparse array (#2411) * MM-13958/MM-13959 Make postsInChannel into a sparse array * Fix unit tests * Fix being unable to load channels with between 30 and 60 posts * Fix unit tests * MM-13960 Re-add support for combined user activity posts (#2465) * Add unit tests for PostList * Remove unnecessary null check * MM-13960 Re-add support for combined user activity posts * Fix being deleted combined posts not disappearing for the user who deletes the post * Fix PostList unit tests * Fix New Messages Below indicator when PostList takes post IDs * Update mattermost-redux * Update mattermost-redux
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes to use the new postsInChannel are mostly in the accompanying redux PR, but I took the opportunity to refactor the post loading logic used by PostList and move it into view actions so that we can test them with the new redux changes.
See mattermost/mattermost-redux#781 for more details.
Mobile PR: mattermost/mattermost-mobile#2600
Redux PR: mattermost/mattermost-redux#781
Ticket Link
https://mattermost.atlassian.net/browse/MM-13958
https://mattermost.atlassian.net/browse/MM-13959
Checklist
make check-styleto check for style errors (required for all pull requests)make testto ensure unit and component tests passed