This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-13957 Reorganize post actions #2343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmhealey
added
2: Dev Review
hmhealey
added
Work in Progress
enahum
approved these changes
Feb 11, 2019
actions/views/rhs.test.js
Outdated
| expect(store.getActions()).toEqual(compareStore.getActions()); | ||
| }); | ||
| }); | ||
|
|
There was a problem hiding this comment.
Shouldn't we just modify tests for showPinnedPosts and showFlaggedPosts instead of deleting?
There was a problem hiding this comment.
I think I deleted them because I don’t think they’re useful tests. They feel like they’re just a copy-paste of the function body. You’re right that I shouldn’t just delete them though, so I’ll take another shot at updating them
hmhealey
added
Awaiting Submitter Action
|
Permalink view isn't working because of the changes to make |
saturninoabril
approved these changes
Feb 26, 2019
saturninoabril
added
4: Reviews Complete
hmhealey
removed
the
Do Not Merge/Awaiting PR
lindy65
added
Tests/Not Needed
amyblais
added
Changelog/Not Needed
hmhealey
added a commit
that referenced
this pull request
Apr 2, 2019
* MM-13957 Reorganize post actions * Use postDeleted action creator * Show join/leave messages since combined systed messages have been temporarily removed * Re-add tests for showFlaggedPosts and showPinnedPosts * Add temporary fix for permalink view * Update mattermost-redux
hmhealey
added a commit
that referenced
this pull request
Apr 15, 2019
) * MM-13957 Reorganize post actions (#2343) * MM-13957 Reorganize post actions * Use postDeleted action creator * Show join/leave messages since combined systed messages have been temporarily removed * Re-add tests for showFlaggedPosts and showPinnedPosts * Add temporary fix for permalink view * Update mattermost-redux * MM-13958/MM-13959 Make postsInChannel into a sparse array (#2411) * MM-13958/MM-13959 Make postsInChannel into a sparse array * Fix unit tests * Fix being unable to load channels with between 30 and 60 posts * Fix unit tests * MM-13960 Re-add support for combined user activity posts (#2465) * Add unit tests for PostList * Remove unnecessary null check * MM-13960 Re-add support for combined user activity posts * Fix being deleted combined posts not disappearing for the user who deletes the post * Fix PostList unit tests * Fix New Messages Below indicator when PostList takes post IDs * Update mattermost-redux * Update mattermost-redux
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the webapp changes to go along with mattermost/mattermost-redux#767. There's nothing really notable about this except I tried to clean up some of the code around getting pinned/flagged posts to have it use more of the mattermost-redux logic.
Ticket Link
https://mattermost.atlassian.net/browse/MM-13957
Checklist