This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
PLT-8231: Add landing page when deep linking to native app #208
Closed
dmeza
wants to merge
4
commits into
mattermost:master
from
uber-archive:landing_page_for_deep_linking_to_native_app
Closed
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
05f9be0
Add landing page when deep linking to native app
d37f4fb
Updating styles for deep linking page
asaadmahmood 54a631d
For testing purposes: Added domain replacement to make tests easier.
9fc7a24
Fixup: fix order of replacement regexp for protocol
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Updating styles for deep linking page
- Loading branch information
commit d37f4fb591663df558672ba991d7414db605df9a
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,7 +5,7 @@ import React, {PureComponent} from 'react'; | |
import {FormattedMessage} from 'react-intl'; | ||
import safeOpenProtocol from 'custom-protocol-detection'; | ||
|
||
import MattermostLogo from 'images/logo.png'; | ||
import MattermostLogoSvg from 'images/logo.svg'; | ||
|
||
export default class GoNativeApp extends PureComponent { | ||
constructor(props) { | ||
|
@@ -54,33 +54,30 @@ export default class GoNativeApp extends PureComponent { | |
|
||
// prompt user to download in case they don't have the mobile app. | ||
return ( | ||
<div | ||
className='get-app get-android-app' | ||
style={{textAlign: 'center', marginTop: '50px'}} | ||
> | ||
<div className='get-app get-app--android'> | ||
<img | ||
src={MattermostLogo} | ||
src={MattermostLogoSvg} | ||
className='get-app__logo' | ||
/> | ||
<div style={{fontSize: '30px', margin: '0 auto 65px'}}> | ||
<div className='get-app__launching'> | ||
<FormattedMessage | ||
id='get_app.launching' | ||
defaultMessage='Launching...' | ||
/> | ||
</div> | ||
<div style={{fontSize: '20px', margin: '0 auto 20px'}}> | ||
<div className='get-app__status'> | ||
{goNativeAppMessage} | ||
</div> | ||
<div> | ||
<div style={{fontSize: '15px', width: '80%', margin: '0 auto'}}> | ||
<div className='get-app__alternative'> | ||
<FormattedMessage | ||
id='get_app.ifNothingPrompts' | ||
defaultMessage='If nothing prompts from browser,' | ||
/> | ||
</div> | ||
<a | ||
href='/downloads' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this URL here should be taken from the config, also it would be ideal if we can detect if the browser is on desktop use the Also this option should be shown only if the setting for |
||
className='btn btn-primary get-android-app__open-mattermost' | ||
className='btn btn-primary get-app__download' | ||
> | ||
<FormattedMessage | ||
id='get_app.downloadMattermost' | ||
|
@@ -90,8 +87,7 @@ export default class GoNativeApp extends PureComponent { | |
</div> | ||
<a | ||
href='/' | ||
className='btn btn-secondary get-android-app__continue-with-browser' | ||
style={{marginTop: '30px'}} | ||
className='btn btn-secondary get-app__continue' | ||
> | ||
<FormattedMessage | ||
id='get_app.continueToBrowser' | ||
|
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing this is true for mobile and desktop apps, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, in case the user doesn't have it installed it should work for mobile and desktop apsp.