PLT-8231: Add landing page when deep linking to native app #208

dmeza · 2017-10-27T04:44:29Z

Summary

These changes add a new route vault to a landing page that allows to fire the protocol to native client if installed or give the user the option to download the native app or redirects to the webapp after 5 seconds.

This is an example if the native app is installed and the protocol is successfully registered:

Ticket Link

mattermost/desktop#628

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

Added or updated unit tests (required for all new features)
Has server changes (please link)
Has redux changes (please link)
Has UI changes
Includes text changes and localization file
Touches critical sections of the codebase (auth, posting, etc.)

jasonblais · 2017-10-27T15:15:16Z

@dmeza Can you help rebase your branch and resolve the build failures?

dmeza · 2017-10-30T16:06:28Z

@jasonblais rebased and fixed build failures.

dmeza · 2017-11-08T20:35:54Z

@jasonblais rebase to the latest.

jasonblais · 2017-11-09T20:24:21Z

Sorry @dmeza for the delay in reviewing this PR. Have asked one of our team members to help take a look

dmeza · 2018-06-25T22:50:15Z

@esethna they are related in that they add support to deeplinking into the mobile app, but it doesn't have anything to do with the landing page or any specific route.

dmeza · 2018-07-08T21:38:17Z

@esethna rebased to latest from master and fixed the order or regexp for protocol to account correctly for https.

esethna · 2018-07-09T17:50:17Z

@enahum have you had a chance to take a look at this PR and comment on the approach?

enahum · 2018-07-11T23:09:55Z

components/go_to_native_app/go_to_native_app.jsx

+ render() {
+ const {protocolUnsupported, browserUnsupported} = this.state;
+
+ let nativeLocation = window.location.href.replace('/vault#', '');


how do I get /vault# in any link, is it have to be added manually when sharing a link?

Also I know the links are handled automatically by the mobile app but that is only true for self compiled apps, not for the mattermost app that is distributed through the app stores, I guess the idea would be to open this, but that keeps me thinking how is that going to be accomplished if the /vault# part of the URL needs to be there.

enahum · 2018-07-11T23:10:16Z

components/go_to_native_app/go_to_native_app.jsx

+ nativeLocation = nativeLocation.replace(/^(https|http)/, 'mattermost');
+
+ //***** TESTING PURPOSE - REMOVE BEFORE MERGE ****
+ nativeLocation = nativeLocation.replace(/\/\/[^/]+/, '//pre-release.mattermost.com');


comment to not forget to remove this

enahum · 2018-07-11T23:11:32Z

components/go_to_native_app/go_to_native_app.jsx

+ );
+ }
+
+ // prompt user to download in case they don't have the mobile app.


I'm guessing this is true for mobile and desktop apps, right?

Yes, in case the user doesn't have it installed it should work for mobile and desktop apsp.

enahum · 2018-07-11T23:14:18Z

components/go_to_native_app/go_to_native_app.jsx

+ />
+ </div>
+ <a
+ href='/downloads'


this URL here should be taken from the config, also it would be ideal if we can detect if the browser is on desktop use the AppDownloadLink setting, for Android use AndroidAppDownloadLink and iOS IosAppDownloadLink

Also this option should be shown only if the setting for EnableMobileDownload is true

enahum · 2018-07-11T23:17:45Z

package.json

@@ -10,6 +10,7 @@
 "bootstrap-colorpicker": "2.5.2",
 "chart.js": "2.7.2",
 "compass-mixins": "0.12.10",
+ "custom-protocol-detection": "uber-uchat/custom-protocol-detection",


is this a fork? if so, what is different from the original library?

Yes, it's a fork and it adds Safari support:
https://github.com/uber-uchat/custom-protocol-detection/commits/master

esethna · 2018-07-11T23:30:35Z

Thanks @enahum. @dmeza let us know if you'd like to jump on a call to discuss further

dmeza · 2018-07-12T17:02:12Z

@esethna @enahum yes, let's have a call tomorrow morning. Then I can show you how it works and answer any questions or concerns.

esethna · 2018-07-13T20:13:57Z

@dmeza thanks for the call today. Action items we discussed would be:

Updating the links in email notifications to the vault route
Admin setting
Potential redesign of the landing page
Ability to save choice for opening webapp

I will follow up on the above, do some more testing and spec out the proposed changes after consulting with the design team.

esethna · 2018-07-25T20:38:51Z

Just an update, design team is working on an updated version of the landing page currently ^

dmeza · 2018-08-18T00:56:58Z

@esethna rebased to the laster from master.

- Add protocol detection for desktop app - fixup to protocol - Moved logic to new router - Renamed folder to be more descriptive. Created proper PureComponent. Fix all issues related to string replacements. Fixed timeOut not working.

* Make get posts actions retry if failed * Add tests for post withRetry methods * Reset attempts when request happens * Change retries check

dmeza mentioned this pull request Oct 27, 2017

Add a server landing page when deep linking to an app when it's not yet installed mattermost/desktop#628

Closed

jasonblais added 1: PM Review Requires review by a product manager Setup Old Test Server Triggers the creation of a test server labels Oct 27, 2017

jasonblais self-assigned this Oct 27, 2017

coreyhulen requested review from hmhealey and crspeller October 27, 2017 15:06

jasonblais removed the Setup Old Test Server Triggers the creation of a test server label Oct 27, 2017

mattermost deleted a comment from mattermod Oct 27, 2017

jasonblais added Awaiting Submitter Action Blocked on the author Hacktoberfest labels Oct 27, 2017

dmeza force-pushed the landing_page_for_deep_linking_to_native_app branch 2 times, most recently from 7e75a0e to 60a776d Compare October 30, 2017 15:34

jasonblais added Setup Old Test Server Triggers the creation of a test server and removed Awaiting Submitter Action Blocked on the author Setup Old Test Server Triggers the creation of a test server labels Oct 30, 2017

mattermost deleted a comment from mattermod Oct 30, 2017

jasonblais added Setup Old Test Server Triggers the creation of a test server and removed Setup Old Test Server Triggers the creation of a test server labels Oct 30, 2017

mattermost deleted a comment from mattermod Oct 30, 2017

jasonblais added the Setup Old Test Server Triggers the creation of a test server label Oct 30, 2017

dmeza force-pushed the landing_page_for_deep_linking_to_native_app branch from 60a776d to 0aa0c8e Compare November 8, 2017 19:55

enahum self-requested a review June 26, 2018 15:25

dmeza force-pushed the landing_page_for_deep_linking_to_native_app branch from c2d5f87 to fcaa325 Compare June 30, 2018 16:45

dmeza force-pushed the landing_page_for_deep_linking_to_native_app branch from fcaa325 to 738049d Compare July 8, 2018 21:25

enahum suggested changes Jul 11, 2018

View reviewed changes

dmeza force-pushed the landing_page_for_deep_linking_to_native_app branch from 738049d to 52b3019 Compare July 13, 2018 15:11

crspeller removed their request for review July 16, 2018 15:48

dmeza force-pushed the landing_page_for_deep_linking_to_native_app branch from 52b3019 to ee8fb8a Compare July 19, 2018 16:29

dmeza force-pushed the landing_page_for_deep_linking_to_native_app branch from ee8fb8a to 7ba74e4 Compare July 26, 2018 15:34

dmeza force-pushed the landing_page_for_deep_linking_to_native_app branch from 7ba74e4 to 9f264ea Compare August 17, 2018 23:05

David Meza and others added 4 commits September 3, 2018 16:05

Add landing page when deep linking to native app

05f9be0

- Add protocol detection for desktop app - fixup to protocol - Moved logic to new router - Renamed folder to be more descriptive. Created proper PureComponent. Fix all issues related to string replacements. Fixed timeOut not working.

Updating styles for deep linking page

d37f4fb

For testing purposes: Added domain replacement to make tests easier.

54a631d

Fixup: fix order of replacement regexp for protocol

9fc7a24

dmeza force-pushed the landing_page_for_deep_linking_to_native_app branch from 9f264ea to 9fc7a24 Compare September 3, 2018 21:05

hanzei removed the Hacktoberfest label Nov 26, 2018

dmeza closed this Dec 7, 2018

dmeza deleted the landing_page_for_deep_linking_to_native_app branch December 7, 2018 18:26

dmeza restored the landing_page_for_deep_linking_to_native_app branch December 7, 2018 18:26

lindalumitchell added the Tests/Not Needed Does not require new release tests label Dec 15, 2018

csduarte mentioned this pull request Jan 29, 2019

Landing page for deep linking to native app new #2299

Closed

3 tasks

hmhealey pushed a commit that referenced this pull request Aug 28, 2020

Getposts optimistic (#208)

d3cf320

* Make get posts actions retry if failed * Add tests for post withRetry methods * Reset attempts when request happens * Change retries check

hmhealey pushed a commit that referenced this pull request Mar 17, 2021

Getposts optimistic (#208)

e7a0ae8

* Make get posts actions retry if failed * Add tests for post withRetry methods * Reset attempts when request happens * Change retries check

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PLT-8231: Add landing page when deep linking to native app #208

PLT-8231: Add landing page when deep linking to native app #208

dmeza commented Oct 27, 2017 •

edited by csduarte

Loading

jasonblais commented Oct 27, 2017

dmeza commented Oct 30, 2017

dmeza commented Nov 8, 2017

jasonblais commented Nov 9, 2017

dmeza commented Jun 25, 2018

dmeza commented Jul 8, 2018

esethna commented Jul 9, 2018

enahum Jul 11, 2018

enahum Jul 11, 2018

enahum Jul 11, 2018

dmeza Jul 13, 2018

enahum Jul 11, 2018

enahum Jul 11, 2018

dmeza Jul 13, 2018

esethna commented Jul 11, 2018

dmeza commented Jul 12, 2018

esethna commented Jul 13, 2018

esethna commented Jul 25, 2018

dmeza commented Aug 18, 2018

PLT-8231: Add landing page when deep linking to native app #208

PLT-8231: Add landing page when deep linking to native app #208

Conversation

dmeza commented Oct 27, 2017 • edited by csduarte Loading

Summary

Ticket Link

Checklist

jasonblais commented Oct 27, 2017

dmeza commented Oct 30, 2017

dmeza commented Nov 8, 2017

jasonblais commented Nov 9, 2017

dmeza commented Jun 25, 2018

dmeza commented Jul 8, 2018

esethna commented Jul 9, 2018

enahum Jul 11, 2018

Choose a reason for hiding this comment

enahum Jul 11, 2018

Choose a reason for hiding this comment

enahum Jul 11, 2018

Choose a reason for hiding this comment

dmeza Jul 13, 2018

Choose a reason for hiding this comment

enahum Jul 11, 2018

Choose a reason for hiding this comment

enahum Jul 11, 2018

Choose a reason for hiding this comment

dmeza Jul 13, 2018

Choose a reason for hiding this comment

esethna commented Jul 11, 2018

dmeza commented Jul 12, 2018

esethna commented Jul 13, 2018

esethna commented Jul 25, 2018

dmeza commented Aug 18, 2018

dmeza commented Oct 27, 2017 •

edited by csduarte

Loading