Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

PLT-8231: Add landing page when deep linking to native app #208

Closed
wants to merge 4 commits into from
Closed

PLT-8231: Add landing page when deep linking to native app #208

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
05f9be0
Add landing page when deep linking to native app
Oct 27, 2017
d37f4fb
Updating styles for deep linking page
asaadmahmood Jan 17, 2018
54a631d
For testing purposes: Added domain replacement to make tests easier.
Jun 15, 2018
9fc7a24
Fixup: fix order of replacement regexp for protocol
Jul 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fixup: fix order of replacement regexp for protocol
  • Loading branch information
David Meza committed Sep 3, 2018
commit 9fc7a24c9b89e14fe7777498c971d69c91d61e4e
2 changes: 1 addition & 1 deletion components/go_to_native_app/go_to_native_app.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export default class GoNativeApp extends PureComponent {
const {protocolUnsupported, browserUnsupported} = this.state;

let nativeLocation = window.location.href.replace('/vault#', '');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how do I get /vault# in any link, is it have to be added manually when sharing a link?

Also I know the links are handled automatically by the mobile app but that is only true for self compiled apps, not for the mattermost app that is distributed through the app stores, I guess the idea would be to open this, but that keeps me thinking how is that going to be accomplished if the /vault# part of the URL needs to be there.

nativeLocation = nativeLocation.replace(/^(http|https)/, 'mattermost');
nativeLocation = nativeLocation.replace(/^(https|http)/, 'mattermost');

//***** TESTING PURPOSE - REMOVE BEFORE MERGE ****
nativeLocation = nativeLocation.replace(/\/\/[^/]+/, '//pre-release.mattermost.com');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment to not forget to remove this

Expand Down