Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-13180 Call load posts earlier for infinite scroll #2079

Merged
merged 4 commits into from
Dec 24, 2018
Merged

MM-13180 Call load posts earlier for infinite scroll #2079

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
20ebebc
MM-13180 Call load posts earlier for infinite scroll
sudheerDev Nov 26, 2018
06679b0
Add check for max height for loading posts
sudheerDev Nov 27, 2018
0901811
Fix issue of loading posts not getting triggered at right position
sudheerDev Dec 20, 2018
7dd10a1
Change the max-value of sctollTop to 2500 for triggering loadPosts
sudheerDev Dec 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion components/post_view/post_list.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@ const POSTS_PER_PAGE = Constants.POST_CHUNK_SIZE / 2;
const MAX_EXTRA_PAGES_LOADED = 10;
const MAX_NUMBER_OF_AUTO_RETRIES = 3;

const LOADPOSTS_MIN_HEIGHT = 300;
const LOADPOSTS_MAX_HEIGHT = 2500;
const LOADPOSTS_SCROLL_RATIO = 0.3;

export default class PostList extends React.PureComponent {
static propTypes = {

Expand Down Expand Up @@ -441,6 +445,7 @@ export default class PostList extends React.PureComponent {
// Only count as user scroll if we've already performed our first load scroll
this.hasScrolled = this.hasScrolledToNewMessageSeparator || this.hasScrolledToFocusedPost;
const postList = this.postListRef.current;
const postListScrollTop = postList.scrollTop;

if (postList.scrollHeight === this.previousScrollHeight) {
this.atBottom = this.checkBottom();
Expand All @@ -462,7 +467,16 @@ export default class PostList extends React.PureComponent {
});
}

if (postList.scrollTop <= 0.5 * postList.clientHeight && !this.state.loadingPosts && !this.state.atEnd && this.state.autoRetryEnable) {
let shouldLoadPosts = false;
const scrollHeightAoveFoldForLoad = LOADPOSTS_SCROLL_RATIO * (postList.scrollHeight - postList.clientHeight);

if (postListScrollTop < LOADPOSTS_MIN_HEIGHT) {
shouldLoadPosts = true;
} else if ((postListScrollTop < LOADPOSTS_MAX_HEIGHT) && (postListScrollTop < scrollHeightAoveFoldForLoad)) {
shouldLoadPosts = true;
}

if (shouldLoadPosts && !this.state.loadingPosts && !this.state.atEnd && this.state.autoRetryEnable) {
this.setState({loadingPosts: true});
this.loadMorePosts();
}
Expand Down