Fixe PR #52
Merged
Fixe PR #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b7d0323.
This was referenced Oct 12, 2021
|
/update-branch |
what does the update branch ? |
|
Well, it should pull in master/main. Seems like it is not configured for this repo yet. |
metanerd
approved these changes
Oct 12, 2021
It is a shortcut in comment for github ? I did knew that it seems very helpfull |
|
Actually no, we have some internal tooling around GitHub. If you want your forks up to date though, I can recommend https://probot.github.io/apps/pull/ . |
This was referenced Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Here is the pull request to fix the issue I open about missing code that I already PR in the previous repository.
This PR is to fix a wrong revert code in #49
@metanerd Please could you have a look into this one ?
Thank you very much and sorry for the mistake
Ticket Link
Fixes #34