Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Mattermost version in env.example #49

Merged
merged 5 commits into from
Oct 12, 2021
Merged

Update Mattermost version in env.example #49

merged 5 commits into from
Oct 12, 2021

Conversation

craph
Copy link
Contributor

@craph craph commented Oct 11, 2021

Summary

Update env.example to reflect latest Mattermost version 5.39.

Ticket Link

None

@craph
Copy link
Contributor Author

craph commented Oct 11, 2021

Sorry for the revert commit. I haven't started from a fresh branch. ;)

@craph
Copy link
Contributor Author

craph commented Oct 11, 2021 •
edited
Loading

@metanerd , @mrckndt ,

May be we can specify the tag latest because in the docherhub we can see that the digest of the 5.39 is equal to the digest of the tag latest. But the tag latest seems pushed 2 days after the 5.39 is it normal ?

What do you prefer ?

@craph
Copy link
Contributor Author

craph commented Oct 12, 2021 •
edited
Loading

Hello @mrckndt, @metanerd

Please could you have a look ?

Best regards,

metanerd
metanerd approved these changes Oct 12, 2021
View reviewed changes
Copy link
Contributor

@metanerd metanerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@metanerd metanerd merged commit 1a4a18e into mattermost:main Oct 12, 2021
@craph
Copy link
Contributor Author

craph commented Oct 12, 2021

Thanks!

@metanerd sorry but it seems this PR revert some changes I did in #46 about TZ

I will recreate a new dedicated PR for that

@metanerd
Copy link
Contributor

GitHub's diff seems to not actually reflect the changes anymore.

@craph
Copy link
Contributor Author

craph commented Oct 12, 2021

GitHub's diff seems to not actually reflect the changes anymore.

I have to recreate a dedicated PR like #46 ?

@craph
Copy link
Contributor Author

craph commented Oct 12, 2021

or can you re apply the changes ?

@craph craph mentioned this pull request Oct 12, 2021
Merged
@craph
Copy link
Contributor Author

craph commented Oct 12, 2021

@metanerd Please could you have a look into the new PR #52 I just pushed. It's to fix the wrong revert in this PR.

I'm very sorry for the mistake.

@craph craph mentioned this pull request Oct 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metanerd metanerd metanerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@craph @metanerd