Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Missing certificate signed by unknown authority refs: https://gi… #46

Merged
merged 2 commits into from
Oct 12, 2021

Conversation

craph
Copy link
Contributor

@craph craph commented Sep 28, 2021

Summary

Here is the pull request to fix the issue I open about missing code that I already PR in the previous repository.

Ticket Link

Fixes #34

@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Sep 30, 2021
@metanerd metanerd requested review from cpanato and removed request for metanerd October 4, 2021 14:11
Copy link
Contributor

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@craph
Copy link
Contributor Author

craph commented Oct 11, 2021

@metanerd , @cpanato do you have an idea when this PR will be merged ?
Best regards,

@cpanato
Copy link
Contributor

cpanato commented Oct 11, 2021

@metanerd , @cpanato do you have an idea when this PR will be merged ? Best regards,

waiting for another review

@craph
Copy link
Contributor Author

craph commented Oct 11, 2021

@mrckndt I added the fix for the timezone here :)
As the TZ variable is defined in the env file, it should be referenced like this :

environment:
   - TZ: ${TZ}

@cpanato, @metanerd this new commit is to fix the timezone issue referenced in the PR #33

@craph
Copy link
Contributor Author

craph commented Oct 12, 2021

Hello @mrckndt,

Please could you have a look ?

Best regards,

@metanerd metanerd requested review from metanerd and removed request for mrckndt October 12, 2021 13:57
Copy link
Contributor

@metanerd metanerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@craph Thank you so much!

@metanerd metanerd merged commit 724a812 into mattermost:main Oct 12, 2021
@craph
Copy link
Contributor Author

craph commented Oct 12, 2021

@craph Thank you so much!

@metanerd You're welcome

@craph
Copy link
Contributor Author

craph commented Oct 12, 2021

@metanerd , @cpanato , @mrckndt I did a new PR #52 for this issue because I made a mistake in #49.

You already accepted and merger those changes but in #49 the changes was revert 😢 I'm very sorry for the mistake.

Thanks to all of you for applying #52 again to fix my mistake.

Best regards,

@hanzei hanzei added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing certificate signed by unknown authority
4 participants